Fix geometry mapping issues for float under inline

third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutObject.h"
 
 #include "core/frame/FrameView.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutView.h"
 #include "platform/json/JSONValues.h"
@@ skipping 106 matching lines @@
       "hidden'></div>"
       "  </div>"
       "</div>");
 
   LayoutObject* overflowClipObject =
       getLayoutObjectByElementId("overflow-clip-layer");
   LayoutBlock* columns = toLayoutBlock(getLayoutObjectByElementId("columns"));
   EXPECT_EQ(columns->layer(), overflowClipObject->paintingLayer());
 }
 
+TEST_F(LayoutObjectTest, FloatUnderInline) {

[chrishtr, 2016/12/16 22:10:30]

Please add more float examples to test your changes to containingBlock &
container. Also verify that your change does not change the answer for any of
them.

[Xianzhu, 2016/12/17 05:43:18]

Added a FloatUnderBlock case, and added test for containingBlock().

We also have a lot of existing float-under-block layout tests, so there should
be enough coverage.

+  enableCompositing();
+  setBodyInnerHTML(
+      "<div id='layered-div' style='position: absolute'>"
+      "  <div id='container'>"
+      "    <span id='layered-span' style='position: relative'>"
+      "      <div id='floating' style='float: left'>FLOAT</div>"
+      "    </span>"
+      "  </div>"
+      "</div>");
+
+  LayoutBoxModelObject* layeredDiv =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("layered-div"));
+  LayoutBoxModelObject* container =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("container"));
+  LayoutBoxModelObject* layeredSpan =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("layered-span"));
+  LayoutObject* floating = getLayoutObjectByElementId("floating");
+
+  EXPECT_EQ(layeredDiv->layer(), layeredDiv->paintingLayer());
+  EXPECT_EQ(layeredSpan->layer(), layeredSpan->paintingLayer());
+  EXPECT_EQ(layeredDiv->layer(), floating->paintingLayer());
+  EXPECT_EQ(container, floating->container());
+}
+
 namespace {
 
 class ScopedSPv2 {
  public:
   ScopedSPv2() { RuntimeEnabledFeatures::setSlimmingPaintV2Enabled(true); }
   ~ScopedSPv2() { m_featuresBackup.restore(); }
 
  private:
   RuntimeEnabledFeatures::Backup m_featuresBackup;
 };
@@ skipping 30 matching lines @@
   EXPECT_FALSE(object->mayNeedPaintInvalidation());
   EXPECT_FALSE(object->mayNeedPaintInvalidationSubtree());
   EXPECT_FALSE(object->mayNeedPaintInvalidationAnimatedBackgroundImage());
   EXPECT_FALSE(object->shouldInvalidateSelection());
   EXPECT_FALSE(object->backgroundChangedSinceLastPaintInvalidation());
   EXPECT_FALSE(object->needsPaintPropertyUpdate());
   EXPECT_FALSE(object->descendantNeedsPaintPropertyUpdate());
 }
 
 }  // namespace blink