DevTools: Animations: Remember the playback rate

third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @implements {SDK.TargetManager.Observer}
  * @unrestricted
  */
 Animation.AnimationTimeline = class extends UI.VBox {
   constructor() {
     super(true);
     this.registerRequiredCSS('animation/animationTimeline.css');
     this.element.classList.add('animations-timeline');
 
     this._grid = this.contentElement.createSVGChild('svg', 'animation-timeline-grid');
 
-    this._playbackRate = 1;
+    this._playbackRateSetting = Common.settings.createSetting('animationPlaybackRate', 1);
+    this._playbackRate = this._playbackRateSetting.get();
     this._allPaused = false;
     this._createHeader();
     this._animationsContainer = this.contentElement.createChild('div', 'animation-timeline-rows');
     var timelineHint = this.contentElement.createChild('div', 'animation-timeline-rows-hint');
     timelineHint.textContent = Common.UIString('Select an effect above to inspect and modify.');
 
     /** @const */ this._defaultDuration = 100;
     this._duration = this._defaultDuration;
     /** @const */ this._timelineControlsWidth = 150;
     /** @type {!Map.<!Protocol.DOM.BackendNodeId, !Animation.AnimationTimeline.NodeUI>} */
@@ skipping 183 matching lines @@
     this._allPaused = !this._allPaused;
     this._pauseButton.setToggled(this._allPaused);
     this._setPlaybackRate(this._playbackRate);
     this._pauseButton.setTitle(this._allPaused ? Common.UIString('Resume all') : Common.UIString('Pause all'));
   }
 
   /**
    * @param {number} playbackRate
    */
   _setPlaybackRate(playbackRate) {
+    this._playbackRateSetting.set(playbackRate);
     this._playbackRate = playbackRate;
     var target = SDK.targetManager.mainTarget();
     if (target)
       Animation.AnimationModel.fromTarget(target).setPlaybackRate(this._allPaused ? 0 : this._playbackRate);
     Host.userMetrics.actionTaken(Host.UserMetrics.Action.AnimationsPlaybackRateChanged);
     if (this._scrubberPlayer)
       this._scrubberPlayer.playbackRate = this._effectivePlaybackRate();
 
     this._updatePlaybackControls();
   }
@@ skipping 85 matching lines @@
     delete this._selectedGroup;
     if (this._scrubberPlayer)
       this._scrubberPlayer.cancel();
     delete this._scrubberPlayer;
     this._currentTime.textContent = '';
     this._updateControlButton();
   }
 
   _reset() {
     this._clearTimeline();
-    if (this._allPaused) {
-      this._playbackRate = 1;
+    if (this._allPaused)
       this._togglePauseAll();
-    } else {
-      this._setPlaybackRate(1);
-    }
+    else
+      this._setPlaybackRate(this._playbackRateSetting.get());

[dgozman, 2016/12/16 05:44:31]

Setting is used to persist between DevTools reopening, which is not the case
here.

Looks like just passing this._playbackRate instead of 1 here fixes the problem?

[einbinder, 2016/12/16 22:37:05]

I thought we wanted it to persist between devtools sessions. Changed.

+
     for (var group of this._groupBuffer)
       group.release();
     this._groupBuffer = [];
     this._previewMap.clear();
     this._previewContainer.removeChildren();
     this._popoverHelper.hidePopover();
     this._renderGrid();
   }
 
   /**
@@ skipping 393 matching lines @@
   static parse(text) {
     var match = text.match(/^steps\((\d+), (start|middle)\)$/);
     if (match)
       return new Animation.AnimationTimeline.StepTimingFunction(parseInt(match[1], 10), match[2]);
     match = text.match(/^steps\((\d+)\)$/);
     if (match)
       return new Animation.AnimationTimeline.StepTimingFunction(parseInt(match[1], 10), 'end');
     return null;
   }
 };