Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Unified Diff: milo/appengine/buildbot/pubsub_test.go

Issue 2575383002: Add server/cache support to gaeconfig. (Closed)
Patch Set: Un-collapse. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « luci_config/appengine/gaeconfig/settings.go ('k') | milo/appengine/logdog/http.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbot/pubsub_test.go
diff --git a/milo/appengine/buildbot/pubsub_test.go b/milo/appengine/buildbot/pubsub_test.go
index 40e64de740abe2e7ba065e06b445207d8dd994e8..825e0bbababb961d4b6421ba320ec7ba74b61a9b 100644
--- a/milo/appengine/buildbot/pubsub_test.go
+++ b/milo/appengine/buildbot/pubsub_test.go
@@ -20,9 +20,9 @@ import (
"github.com/luci/gae/impl/memory"
ds "github.com/luci/gae/service/datastore"
"github.com/luci/luci-go/common/clock/testclock"
- lucicfg "github.com/luci/luci-go/common/config"
memcfg "github.com/luci/luci-go/common/config/impl/memory"
"github.com/luci/luci-go/common/logging/gologger"
+ "github.com/luci/luci-go/luci_config/server/cfgclient/backend/testconfig"
"github.com/luci/luci-go/milo/appengine/settings"
"github.com/luci/luci-go/server/auth"
"github.com/luci/luci-go/server/auth/authtest"
@@ -432,7 +432,8 @@ func TestPubSub(t *testing.T) {
})
So(h.Code, ShouldEqual, 200)
Convey("And stores correctly", func() {
- c = lucicfg.SetImplementation(c, memcfg.New(aclConfgs))
+ c = testconfig.WithCommonClient(c, memcfg.New(aclConfgs))
+
err := settings.Update(c)
So(err, ShouldBeNil)
c = auth.WithState(c, &authtest.FakeState{
« no previous file with comments | « luci_config/appengine/gaeconfig/settings.go ('k') | milo/appengine/logdog/http.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698