Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2230)

Unified Diff: dm/appengine/distributor/registry.go

Issue 2575383002: Add server/cache support to gaeconfig. (Closed)
Patch Set: Un-collapse. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/appengine/distributor/fake/fake.go ('k') | logdog/appengine/coordinator/auth.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/appengine/distributor/registry.go
diff --git a/dm/appengine/distributor/registry.go b/dm/appengine/distributor/registry.go
index 75281489612906b919bdf15d79f81530a9a2e734..3c78b86c41e4cf1a8713d0b3cdd41f6fa7beb3b4 100644
--- a/dm/appengine/distributor/registry.go
+++ b/dm/appengine/distributor/registry.go
@@ -9,13 +9,16 @@ import (
"fmt"
"reflect"
- "github.com/golang/protobuf/proto"
"github.com/luci/gae/service/info"
- "github.com/luci/luci-go/common/config"
"github.com/luci/luci-go/common/logging"
"github.com/luci/luci-go/dm/api/distributor"
"github.com/luci/luci-go/dm/api/service/v1"
+ "github.com/luci/luci-go/luci_config/server/cfgclient"
+ "github.com/luci/luci-go/luci_config/server/cfgclient/textproto"
"github.com/luci/luci-go/tumble"
+
+ "github.com/golang/protobuf/proto"
+
"golang.org/x/net/context"
)
@@ -122,18 +125,17 @@ func (r *registry) MakeDistributor(c context.Context, cfgName string) (d D, ver
// loadConfig loads the named distributor configuration from luci-config,
// possibly using the in-memory or memcache version.
func loadConfig(c context.Context, cfgName string) (ret *Config, err error) {
- aid := info.TrimmedAppID(c)
- distCfgObj, err := config.GetConfig(c, fmt.Sprintf("services/%s", aid), "distributors.cfg", false)
- if err != nil {
- return
- }
+ configSet := cfgclient.CurrentServiceConfigSet(c)
- cfgVersion := distCfgObj.Revision
- distCfg := &distributor.Config{}
- if err = proto.UnmarshalText(distCfgObj.Content, distCfg); err != nil {
+ var (
+ distCfg distributor.Config
+ meta cfgclient.Meta
+ )
+ if err = cfgclient.Get(c, cfgclient.AsService, configSet, "distributors.cfg", textproto.Message(&distCfg), &meta); err != nil {
return
}
+ cfgVersion := meta.Revision
cfg, ok := distCfg.DistributorConfigs[cfgName]
if !ok {
err = fmt.Errorf("unknown distributor configuration: %q", cfgName)
« no previous file with comments | « dm/appengine/distributor/fake/fake.go ('k') | logdog/appengine/coordinator/auth.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698