Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: common/config/filters/caching/config_test.go

Issue 2575383002: Add server/cache support to gaeconfig. (Closed)
Patch Set: Un-collapse. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « common/config/filters/caching/config.go ('k') | common/config/filters/caching/doc.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common/config/filters/caching/config_test.go
diff --git a/common/config/filters/caching/config_test.go b/common/config/filters/caching/config_test.go
deleted file mode 100644
index d419f18e04bc8d07e363af76b4a210c4230e3c3d..0000000000000000000000000000000000000000
--- a/common/config/filters/caching/config_test.go
+++ /dev/null
@@ -1,388 +0,0 @@
-// Copyright 2015 The LUCI Authors. All rights reserved.
-// Use of this source code is governed under the Apache License, Version 2.0
-// that can be found in the LICENSE file.
-
-package caching
-
-import (
- "errors"
- "net/url"
- "testing"
- "time"
-
- "github.com/luci/luci-go/common/config"
- "github.com/luci/luci-go/common/config/impl/memory"
- "golang.org/x/net/context"
-
- . "github.com/luci/luci-go/common/testing/assertions"
- . "github.com/smartystreets/goconvey/convey"
-)
-
-type testCache struct {
- data map[string][]byte
- callback func(hit bool)
-}
-
-func (tc *testCache) Store(c context.Context, key string, expire time.Duration, value []byte) {
- if tc.data == nil {
- tc.data = map[string][]byte{}
- }
- tc.data[key] = value
-}
-
-func (tc *testCache) Retrieve(c context.Context, key string) []byte {
- d, ok := tc.data[key]
- if tc.callback != nil {
- tc.callback(ok)
- }
- return d
-}
-
-func (tc *testCache) invalidate() {
- tc.data = nil
-}
-
-func (tc *testCache) nothingCached() bool {
- return len(tc.data) == 0
-}
-
-type forceErrConfig struct {
- inner config.Interface
- err error
-}
-
-func (tc *forceErrConfig) ServiceURL(ctx context.Context) url.URL {
- return tc.inner.ServiceURL(ctx)
-}
-
-func (tc *forceErrConfig) GetConfig(ctx context.Context, configSet, path string, hashOnly bool) (*config.Config, error) {
- if tc.err != nil {
- return nil, tc.err
- }
- return tc.inner.GetConfig(ctx, configSet, path, hashOnly)
-}
-
-func (tc *forceErrConfig) GetConfigByHash(ctx context.Context, contentHash string) (string, error) {
- if tc.err != nil {
- return "", tc.err
- }
- return tc.inner.GetConfigByHash(ctx, contentHash)
-}
-
-func (tc *forceErrConfig) GetConfigSetLocation(ctx context.Context, configSet string) (*url.URL, error) {
- if tc.err != nil {
- return nil, tc.err
- }
- return tc.inner.GetConfigSetLocation(ctx, configSet)
-}
-
-func (tc *forceErrConfig) GetProjectConfigs(ctx context.Context, path string, hashesOnly bool) ([]config.Config, error) {
- if tc.err != nil {
- return nil, tc.err
- }
- return tc.inner.GetProjectConfigs(ctx, path, hashesOnly)
-}
-
-func (tc *forceErrConfig) GetProjects(ctx context.Context) ([]config.Project, error) {
- if tc.err != nil {
- return nil, tc.err
- }
- return tc.inner.GetProjects(ctx)
-}
-
-func (tc *forceErrConfig) GetRefConfigs(ctx context.Context, path string, hashesOnly bool) ([]config.Config, error) {
- if tc.err != nil {
- return nil, tc.err
- }
- return tc.inner.GetRefConfigs(ctx, path, hashesOnly)
-}
-
-func (tc *forceErrConfig) GetRefs(ctx context.Context, projectID string) ([]string, error) {
- if tc.err != nil {
- return nil, tc.err
- }
- return tc.inner.GetRefs(ctx, projectID)
-}
-
-func TestConfig(t *testing.T) {
- t.Parallel()
-
- Convey(`A cache backed by a memory Config`, t, func() {
- c := context.Background()
- mbase := map[string]memory.ConfigSet{
- "services/foo": {
- "file": "body",
- },
- "projects/proj1": {
- "file": "project1 file",
- },
- "projects/goesaway": {
- "file": "project1 file",
- },
- "projects/goesaway/refs/heads/master": {
- "file": "goesaway master ref",
- },
- "projects/goesaway/refs/heads/other": {
- "file": "goesaway other ref",
- },
- }
- mcfg := memory.New(mbase)
- errCfg := &forceErrConfig{inner: mcfg}
-
- wasHit := false
- tc := testCache{
- callback: func(hit bool) { wasHit = hit },
- }
-
- cfg := Wrap(errCfg, Options{
- Cache: &tc,
- })
-
- // Advance underlying config, expectation.
- advance := func() {
- mbase["services/foo"]["file"] = "body2"
- delete(mbase, "projects/goesaway")
- delete(mbase, "projects/goesaway/refs/heads/master")
- delete(mbase, "projects/goesaway/refs/heads/other")
- }
-
- Convey(`GetConfig`, func() {
- Convey(`A non-hash-only query retrieves and caches the full body.`, func() {
- exp, _ := mcfg.GetConfig(c, "services/foo", "file", false)
-
- v, err := cfg.GetConfig(c, "services/foo", "file", false)
- So(err, ShouldBeNil)
- So(v, ShouldResemble, exp)
-
- advance()
- v, err = cfg.GetConfig(c, "services/foo", "file", false)
- So(err, ShouldBeNil)
- So(v, ShouldResemble, exp)
-
- Convey(`A hash-only query will use non-hash version.`, func() {
- v, err = cfg.GetConfig(c, "services/foo", "file", true)
- So(err, ShouldBeNil)
- So(v, ShouldResemble, exp)
- })
-
- Convey(`A non-hash-only query caches by hash too.`, func() {
- byHash, err := cfg.GetConfigByHash(c, v.ContentHash)
- So(err, ShouldBeNil)
- So(byHash, ShouldResemble, v.Content)
- })
- })
-
- Convey(`A hash-only query will cache the hashed version.`, func() {
- exp, _ := mcfg.GetConfig(c, "services/foo", "file", true)
-
- v, err := cfg.GetConfig(c, "services/foo", "file", true)
- So(err, ShouldBeNil)
- So(v, ShouldResemble, exp)
-
- advance()
- v, err = cfg.GetConfig(c, "services/foo", "file", true)
- So(err, ShouldBeNil)
- So(v, ShouldResemble, exp)
-
- Convey(`A full query will not use the cached hash-only version.`, func() {
- exp, _ := mcfg.GetConfig(c, "services/foo", "file", false)
-
- v, err = cfg.GetConfig(c, "services/foo", "file", false)
- So(err, ShouldBeNil)
- So(v, ShouldResemble, exp)
- })
-
- Convey(`A hash-only query does not cache the full config by hash.`, func() {
- _, err := cfg.GetConfigByHash(c, v.ContentHash)
- So(err, ShouldNotBeNil)
- })
- })
-
- Convey(`GetConfig missing will be cached`, func() {
- _, err := cfg.GetConfig(c, "services/invalid", "file", false)
- So(err, ShouldEqual, config.ErrNoConfig)
- So(wasHit, ShouldBeFalse)
-
- _, err = cfg.GetConfig(c, "services/invalid", "file", false)
- So(err, ShouldEqual, config.ErrNoConfig)
- So(wasHit, ShouldBeTrue)
- })
-
- Convey(`Other errors will not be cached`, func() {
- errCfg.err = errors.New("test error")
- _, err := cfg.GetConfig(c, "services/foo", "file", false)
- So(err, ShouldErrLike, "test error")
- So(tc.nothingCached(), ShouldBeTrue)
- })
- })
-
- Convey(`GetConfigByHash`, func() {
- Convey(`Works.`, func() {
- body, err := cfg.GetConfigByHash(c, "v1:fb4c35e739d53994aba7d3e0416a1082f11bfbba")
- So(err, ShouldBeNil)
- So(body, ShouldResemble, "body")
-
- advance()
- body, err = cfg.GetConfigByHash(c, "v1:fb4c35e739d53994aba7d3e0416a1082f11bfbba")
- So(err, ShouldBeNil)
- So(body, ShouldResemble, "body")
- })
-
- Convey(`Missing caches and returns error`, func() {
- _, err := cfg.GetConfigByHash(c, "v0:asdf")
- So(err, ShouldEqual, config.ErrNoConfig)
- So(wasHit, ShouldBeFalse)
-
- _, err = cfg.GetConfigByHash(c, "v0:asdf")
- So(err, ShouldEqual, config.ErrNoConfig)
- So(wasHit, ShouldBeTrue)
- })
-
- Convey(`Other errors will not be cached`, func() {
- errCfg.err = errors.New("test error")
- _, err := cfg.GetConfigByHash(c, "v0:asdf")
- So(err, ShouldErrLike, "test error")
- So(tc.nothingCached(), ShouldBeTrue)
- })
- })
-
- Convey(`GetConfigSetLocation`, func() {
- Convey(`Works.`, func() {
- loc, err := cfg.GetConfigSetLocation(c, "projects/goesaway")
- So(err, ShouldBeNil)
- So(loc, ShouldNotBeNil)
-
- advance()
- loc2, err := cfg.GetConfigSetLocation(c, "projects/goesaway")
- So(err, ShouldBeNil)
- So(loc2, ShouldResemble, loc)
- })
-
- Convey(`Missing caches and returns error`, func() {
- errCfg.err = config.ErrNoConfig
- _, err := cfg.GetConfigSetLocation(c, "projects/goesaway")
- So(err, ShouldEqual, config.ErrNoConfig)
- So(wasHit, ShouldBeFalse)
-
- _, err = cfg.GetConfigSetLocation(c, "projects/goesaway")
- So(err, ShouldEqual, config.ErrNoConfig)
- So(wasHit, ShouldBeTrue)
- })
-
- Convey(`Other errors will not be cached`, func() {
- errCfg.err = errors.New("test error")
- _, err := cfg.GetConfigSetLocation(c, "projects/goesaway")
- So(err, ShouldErrLike, "test error")
- So(tc.nothingCached(), ShouldBeTrue)
- })
- })
-
- Convey(`GetProjectConfigs`, func() {
- Convey(`Works.`, func() {
- exp, _ := mcfg.GetProjectConfigs(c, "file", false)
-
- cfgs, err := cfg.GetProjectConfigs(c, "file", false)
- So(err, ShouldBeNil)
- So(cfgs, ShouldResemble, exp)
-
- advance()
- cfgs, err = cfg.GetProjectConfigs(c, "file", false)
- So(err, ShouldBeNil)
- So(cfgs, ShouldResemble, exp)
-
- Convey(`Hash-only will returned cached full content.`, func() {
- cfgs, err = cfg.GetProjectConfigs(c, "file", true)
- So(err, ShouldBeNil)
- So(cfgs, ShouldResemble, exp)
- })
- })
-
- Convey(`Hash-only works.`, func() {
- exp, _ := mcfg.GetProjectConfigs(c, "file", true)
-
- cfgs, err := cfg.GetProjectConfigs(c, "file", true)
- So(err, ShouldBeNil)
- So(cfgs, ShouldResemble, exp)
-
- Convey(`Full query will not use hash-only cached version.`, func() {
- advance()
- exp, _ := mcfg.GetProjectConfigs(c, "file", false)
-
- cfgs, err := cfg.GetProjectConfigs(c, "file", false)
- So(err, ShouldBeNil)
- So(cfgs, ShouldResemble, exp)
- })
- })
- })
-
- Convey(`GetProjects`, func() {
- Convey(`Works.`, func() {
- exp, _ := mcfg.GetProjects(c)
- proj, err := cfg.GetProjects(c)
- So(err, ShouldBeNil)
- So(proj, ShouldResemble, exp)
-
- advance()
- exp2, _ := mcfg.GetProjects(c)
- proj, err = cfg.GetProjects(c)
- So(err, ShouldBeNil)
- So(proj, ShouldResemble, exp)
- So(proj, ShouldNotResemble, exp2)
- })
- })
-
- Convey(`GetRefConfigs`, func() {
- Convey(`Works.`, func() {
- exp, _ := mcfg.GetRefConfigs(c, "file", false)
-
- cfgs, err := cfg.GetRefConfigs(c, "file", false)
- So(err, ShouldBeNil)
- So(cfgs, ShouldResemble, exp)
-
- advance()
- cfgs, err = cfg.GetRefConfigs(c, "file", false)
- So(err, ShouldBeNil)
- So(cfgs, ShouldResemble, exp)
-
- Convey(`Hash-only will returned cached full content.`, func() {
- cfgs, err = cfg.GetRefConfigs(c, "file", true)
- So(err, ShouldBeNil)
- So(cfgs, ShouldResemble, exp)
- })
- })
-
- Convey(`Hash-only works.`, func() {
- exp, _ := mcfg.GetRefConfigs(c, "file", true)
-
- cfgs, err := cfg.GetRefConfigs(c, "file", true)
- So(err, ShouldBeNil)
- So(cfgs, ShouldResemble, exp)
-
- Convey(`Full query will not use hash-only cached version.`, func() {
- advance()
- exp, _ := mcfg.GetRefConfigs(c, "file", false)
-
- cfgs, err := cfg.GetRefConfigs(c, "file", false)
- So(err, ShouldBeNil)
- So(cfgs, ShouldResemble, exp)
- })
- })
- })
-
- Convey(`GetRefs`, func() {
- Convey(`Works.`, func() {
- exp, _ := mcfg.GetRefs(c, "goesaway")
- proj, err := cfg.GetRefs(c, "goesaway")
- So(err, ShouldBeNil)
- So(proj, ShouldResemble, exp)
-
- advance()
- exp2, _ := mcfg.GetRefs(c, "goesaway")
- proj, err = cfg.GetRefs(c, "goesaway")
- So(err, ShouldBeNil)
- So(proj, ShouldResemble, exp)
- So(proj, ShouldNotResemble, exp2)
- })
- })
- })
-}
« no previous file with comments | « common/config/filters/caching/config.go ('k') | common/config/filters/caching/doc.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698