Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: dm/appengine/distributor/fake/fake.go

Issue 2575383002: Add server/cache support to gaeconfig. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dm/appengine/distributor/fake/fake.go
diff --git a/dm/appengine/distributor/fake/fake.go b/dm/appengine/distributor/fake/fake.go
index a1c3efdbaeeb3c8fdd0fd3354b68170a2d8ade18..2cdcf33f99109032b6e70e8f8457f00e000f4e6a 100644
--- a/dm/appengine/distributor/fake/fake.go
+++ b/dm/appengine/distributor/fake/fake.go
@@ -11,8 +11,6 @@ import (
"sync"
"time"
- "github.com/golang/protobuf/proto"
- "github.com/luci/luci-go/common/config"
config_mem "github.com/luci/luci-go/common/config/impl/memory"
"github.com/luci/luci-go/common/gcloud/pubsub"
googlepb "github.com/luci/luci-go/common/proto/google"
@@ -23,8 +21,11 @@ import (
"github.com/luci/luci-go/server/auth"
"github.com/luci/luci-go/server/auth/authtest"
"github.com/luci/luci-go/server/auth/identity"
+ "github.com/luci/luci-go/server/config/testconfig"
"github.com/luci/luci-go/server/secrets/testsecrets"
"github.com/luci/luci-go/tumble"
+
+ "github.com/golang/protobuf/proto"
"github.com/smartystreets/goconvey/convey"
"golang.org/x/net/context"
)
@@ -55,11 +56,12 @@ func Setup(fn distributor.FinishExecutionFn) (ttest *tumble.Testing, c context.C
ttest = &tumble.Testing{}
c = ttest.Context()
c = testsecrets.Use(c)
- c = config.SetImplementation(c, config_mem.New(map[string]config_mem.ConfigSet{
+
+ c = testconfig.WithCommonClient(c, config_mem.New(map[string]config_mem.ConfigSet{
"services/app": {
"acls.cfg": `
- readers: "reader_group"
- writers: "writer_group"
+ readers: "reader_group"
+ writers: "writer_group"
`,
},
}))

Powered by Google App Engine
This is Rietveld 408576698