Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/gaemiddleware/context.go

Issue 2575383002: Add server/cache support to gaeconfig. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« appengine/gaeconfig/default.go ('K') | « appengine/gaeconfig/settings.go ('k') | common/config/context.go » ('j') | logdog/appengine/coordinator/auth.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/gaemiddleware/context.go
diff --git a/appengine/gaemiddleware/context.go b/appengine/gaemiddleware/context.go
index 9205eca7b7b78fc0c4dde82a1950bdfb7de35d39..a31b02a362d398f2d8225da4d4fcfa24ec00b71c 100644
--- a/appengine/gaemiddleware/context.go
+++ b/appengine/gaemiddleware/context.go
@@ -14,7 +14,6 @@ import (
"github.com/luci/gae/impl/prod"
"github.com/luci/gae/service/urlfetch"
- "github.com/luci/luci-go/common/config"
"github.com/luci/luci-go/common/data/caching/cacheContext"
"github.com/luci/luci-go/common/data/caching/proccache"
"github.com/luci/luci-go/common/logging"
@@ -87,7 +86,7 @@ func WithProd(c context.Context, req *http.Request) context.Context {
// The rest of the service may use applied configuration.
c = proccache.Use(c, globalProcessCache)
- c = config.SetImplementation(c, gaeconfig.New(c))
+ c = gaeconfig.Use(c)
c = gaesecrets.Use(c, nil)
c = auth.SetConfig(c, globalAuthConfig)
return cacheContext.Wrap(c)
« appengine/gaeconfig/default.go ('K') | « appengine/gaeconfig/settings.go ('k') | common/config/context.go » ('j') | logdog/appengine/coordinator/auth.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698