Add server/cache support to gaeconfig.

logdog/appengine/coordinator/auth.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package coordinator
 
 import (
         "fmt"
         "strings"
 
@@ skipping 53 matching lines @@
                 if u := auth.CurrentUser(c); u.Superuser {
                         log.Fields{
                                 "identity": u.Identity,
                                 "groups":   groups,
                         }.Infof(c, "Granting superuser implicit group membership on development server.")
                         return nil
                 }
         }
 
         id := auth.CurrentIdentity(c)
+
+        // Artifically handle "all".

[iannucci, 2017/01/07 21:05:26]

:( (for previous 'all is a valid group name' reasons)

[dnj, 2017/01/10 03:30:07]

Actually this can die now.

         for _, group := range groups {
-                is, err := auth.IsMember(c, group)
-                if err != nil {
-                        return err
-                }
-                if is {
-                        log.Fields{
-                                "identity": id,
-                                "group":    group,
-                        }.Debugf(c, "User access granted.")
+                if group == "all" {
+                        log.Debugf(c, "User access granted for 'all'.")
                         return nil
                 }
         }
 
+        is, err := auth.IsMember(c, groups...)
+        if err != nil {
+                return err
+        }
+        if is {
+                log.Fields{
+                        "identity": id,
+                        "group":    groups,
+                }.Debugf(c, "User access granted.")
+                return nil
+        }
+
         return &MembershipError{
                 Identity: id,
                 Groups:   groups,
         }
 }
 
 // MembershipError is an error returned by group membership checking functions
 // if the current identity is not a member of the requested group.
 type MembershipError struct {
         Identity identity.Identity
         Groups   []string
 }
 
 func (e *MembershipError) Error() string {
         return fmt.Sprintf("user %q is not a member of [%s]", e.Identity, strings.Join(e.Groups, ", "))
 }
 
 // IsMembershipError returns whether a given error is a membership error.
 func IsMembershipError(e error) bool {
         _, ok := e.(*MembershipError)
         return ok
 }