Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: pkg/analyzer/test/src/dart/analysis/driver_test.dart

Issue 2575353002: Another hermetic test for a case found in instrumentation logs. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/dart/analysis/driver_test.dart
diff --git a/pkg/analyzer/test/src/dart/analysis/driver_test.dart b/pkg/analyzer/test/src/dart/analysis/driver_test.dart
index 65c4f8e21530cce244fff8132eb2a24a667c3fc8..e5884b98113fc542cffbc97a421f1d64a603930d 100644
--- a/pkg/analyzer/test/src/dart/analysis/driver_test.dart
+++ b/pkg/analyzer/test/src/dart/analysis/driver_test.dart
@@ -10,6 +10,7 @@ import 'dart:convert';
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/standard_resolution_map.dart';
import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/type.dart';
import 'package:analyzer/error/error.dart';
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/file_system/memory_file_system.dart';
@@ -1003,6 +1004,70 @@ main() {
expect(driver.hasFilesToAnalyze, isFalse);
}
+ test_hermetic_modifyLibraryFile_resolvePart() async {
+ var a = _p('/test/lib/a.dart');
+ var b = _p('/test/lib/b.dart');
+
+ provider.newFile(
+ a,
+ r'''
+library a;
+part 'b.dart';
+class C {
+ int foo;
+}
+''');
+ provider.newFile(
+ b,
+ r'''
+part of a;
+var c = new C();
+''');
+
+ driver.addFile(a);
+ driver.addFile(b);
+
+ await driver.getResult(b);
+
+ // Modify the library, but don't notify the driver.
+ // The driver should use the previous library content and elements.
+ provider.newFile(
+ a,
+ r'''
+library a;
+part 'b.dart';
+class C {
+ int bar;
+}
+''');
+
+ var result = await driver.getResult(b);
+ var c = _getTopLevelVar(result.unit, 'c');
+ var typeC = c.element.type as InterfaceType;
+ // The class C has an old field 'foo', not the new 'bar'.
+ expect(typeC.element.getField('foo'), isNotNull);
+ expect(typeC.element.getField('bar'), isNull);
+ }
+
+ test_hermetic_overlayOnly_part() async {
+ var a = _p('/test/lib/a.dart');
+ var b = _p('/test/lib/b.dart');
+ contentOverlay[a] = r'''
+library a;
+part 'b.dart';
+class A {}
+var b = new B();
+''';
+ contentOverlay[b] = 'part of a; class B {}';
+
+ driver.addFile(a);
+ driver.addFile(b);
+
+ AnalysisResult result = await driver.getResult(a);
+ expect(result.errors, isEmpty);
+ expect(_getTopLevelVarType(result.unit, 'b'), 'B');
+ }
+
test_knownFiles() async {
var a = _p('/test/lib/a.dart');
var b = _p('/test/lib/b.dart');
@@ -1163,25 +1228,6 @@ var b = new B();
expect(result.unit, isNotNull);
}
- test_part_getResult_overlayOnly() async {
- var a = _p('/test/lib/a.dart');
- var b = _p('/test/lib/b.dart');
- contentOverlay[a] = r'''
-library a;
-part 'b.dart';
-class A {}
-var b = new B();
-''';
- contentOverlay[b] = 'part of a; class B {}';
-
- driver.addFile(a);
- driver.addFile(b);
-
- AnalysisResult result = await driver.getResult(a);
- expect(result.errors, isEmpty);
- expect(_getTopLevelVarType(result.unit, 'b'), 'B');
- }
-
test_part_results_afterLibrary() async {
var a = _p('/test/lib/a.dart');
var b = _p('/test/lib/b.dart');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698