third_party/WebKit/Source/core/html/HTMLLinkElement.cpp - Issue 2575273002: Fix empty href for favicon link element causing page to be fetched twice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

Issue 2575273002: Fix empty href for favicon link element causing page to be fetched twice. (Closed)

Patch Set: Update test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp b/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

index e3baf910d492c2287c9c1a5f97b1bcde1a9b0cd1..ae4f4dd33c61a07379bb4d6c073955834bde5257 100644

--- a/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

@@ -324,7 +324,10 @@ const QualifiedName& HTMLLinkElement::subResourceAttributeName() const {

}

KURL HTMLLinkElement::href() const {

- return document().completeURL(getAttribute(hrefAttr));

+ const String& url = getAttribute(hrefAttr);

+ if (url.isEmpty())

+ return KURL();

+ return document().completeURL(url);

}

const AtomicString& HTMLLinkElement::rel() const {