Chromium Code Reviews Chromium Code Reviews
Issue 2575273002:
Fix empty href for favicon link element causing page to be fetched twice. (Closed)
| Index: third_party/WebKit/Source/core/html/HTMLLinkElementTest.cpp |
| diff --git a/third_party/WebKit/Source/core/html/HTMLLinkElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLLinkElementTest.cpp |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..a5c876c3f256e4d0750eb81ea4ad60e05745f7b1 |
| --- /dev/null |
| +++ b/third_party/WebKit/Source/core/html/HTMLLinkElementTest.cpp |
| @@ -0,0 +1,52 @@ |
| +// Copyright 2016 The Chromium Authors. All rights reserved. |
| +// Use of this source code is governed by a BSD-style license that can be |
| +// found in the LICENSE file. |
| + |
| +#include "core/html/HTMLLinkElement.h" |
| + |
| +#include "core/dom/Document.h" |
| +#include "core/frame/FrameView.h" |
| +#include "core/html/HTMLHeadElement.h" |
| +#include "core/testing/DummyPageHolder.h" |
| + |
|
tkent
2016/12/15 01:20:03
Remove the blank line
lpy
2016/12/15 01:25:39
Done.
|
| +#include "testing/gmock/include/gmock/gmock.h" |
| +#include "testing/gtest/include/gtest/gtest.h" |
| + |
| +namespace blink { |
| + |
| +class HTMLLinkElementTest : public ::testing::Test { |
| + protected: |
| + void SetUp() override; |
| + |
| + void TearDown() override { ThreadState::current()->collectAllGarbage(); } |
|
tkent
2016/12/15 01:20:03
We don't need collectAllGarbage() here. There are
lpy
2016/12/15 01:25:39
Done.
|
| + |
| + Document& document() const { return m_dummyPageHolder->document(); } |
| + |
| + void setHtmlInnerHTML(const char*); |
| + |
| + private: |
| + std::unique_ptr<DummyPageHolder> m_dummyPageHolder; |
| +}; |
| + |
| +void HTMLLinkElementTest::SetUp() { |
| + m_dummyPageHolder = DummyPageHolder::create(IntSize(800, 600)); |
| +} |
| + |
| +void HTMLLinkElementTest::setHtmlInnerHTML(const char* htmlContent) { |
| + document().documentElement()->setInnerHTML(String::fromUTF8(htmlContent)); |
| + document().view()->updateAllLifecyclePhases(); |
|
tkent
2016/12/15 01:20:03
updateAllLifecyclePhases() is unnecessary. Then,
lpy
2016/12/15 01:25:39
Done.
|
| +} |
| + |
| +// This tests that we should ignore empty string value |
| +// in href attribute value of the link element. |
| +TEST_F(HTMLLinkElementTest, href) { |
|
tkent
2016/12/15 01:20:03
The test name should be more specific. e.g. TEST_
lpy
2016/12/15 01:25:39
Done.
|
| + setHtmlInnerHTML( |
| + "<head>" |
| + "<link rel=\"icon\" type=\"image/ico\" href=\"\" />" |
| + "</head>"); |
| + HTMLLinkElement* linkElement = |
| + toElement<HTMLLinkElement>(document().head()->firstChild()); |
| + EXPECT_EQ(KURL(), linkElement->href()); |
| +} |
| + |
| +} // namespace blink |
