Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Side by Side Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2575263002: [Autofill] Add a new metric for upstream. (Closed)
Patch Set: Resolve comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <string> 9 #include <string>
10 10
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 // to fill. 355 // to fill.
356 FORM_EVENT_SERVER_SUGGESTION_FILLED, 356 FORM_EVENT_SERVER_SUGGESTION_FILLED,
357 // A masked server card suggestion was used to fill the form. 357 // A masked server card suggestion was used to fill the form.
358 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_FILLED, 358 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_FILLED,
359 // A suggestion was used to fill the form. The origin type (local or server 359 // A suggestion was used to fill the form. The origin type (local or server
360 // or masked server card) of the first selected within a page load will 360 // or masked server card) of the first selected within a page load will
361 // determine which of the following two will be fired. 361 // determine which of the following two will be fired.
362 FORM_EVENT_LOCAL_SUGGESTION_FILLED_ONCE, 362 FORM_EVENT_LOCAL_SUGGESTION_FILLED_ONCE,
363 FORM_EVENT_SERVER_SUGGESTION_FILLED_ONCE, 363 FORM_EVENT_SERVER_SUGGESTION_FILLED_ONCE,
364 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_FILLED_ONCE, 364 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_FILLED_ONCE,
365 // A dropdown with suggestions was shown and a form was submitted after that
366 FORM_EVENT_SUGGESTION_SHOWN_SUBMITTED_ONCE,
Jared Saul 2016/12/15 22:20:59 Looks like this is a duplicate now; remove?
Shanfeng 2016/12/15 23:28:12 Done.
365 // A form was submitted. Depending on the user filling a local, server, 367 // A form was submitted. Depending on the user filling a local, server,
366 // masked server card or no suggestion one of the following will be 368 // masked server card or no suggestion one of the following will be
367 // triggered. Only one of the following four will be triggered per page 369 // triggered. Only one of the following four will be triggered per page
368 // load. 370 // load.
369 FORM_EVENT_NO_SUGGESTION_SUBMITTED_ONCE, 371 FORM_EVENT_NO_SUGGESTION_SUBMITTED_ONCE,
370 FORM_EVENT_LOCAL_SUGGESTION_SUBMITTED_ONCE, 372 FORM_EVENT_LOCAL_SUGGESTION_SUBMITTED_ONCE,
371 FORM_EVENT_SERVER_SUGGESTION_SUBMITTED_ONCE, 373 FORM_EVENT_SERVER_SUGGESTION_SUBMITTED_ONCE,
372 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SUBMITTED_ONCE, 374 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SUBMITTED_ONCE,
373 // A masked server card suggestion was selected to fill the form. 375 // A masked server card suggestion was selected to fill the form.
374 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SELECTED, 376 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SELECTED,
375 // Same as above but only triggered once per page load. 377 // Same as above but only triggered once per page load.
376 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SELECTED_ONCE, 378 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SELECTED_ONCE,
379 // A dropdown with suggestions was shown and a form was submitted after that
Jared Saul 2016/12/15 22:20:59 nit: s/that/that. (for consistency; all the others
Shanfeng 2016/12/15 23:28:12 Done.
380 FORM_EVENT_SUGGESTION_SHOWN_SUBMITTED_ONCE,
381 // A dropdown with suggestions was shown and a form is about to be
382 // submitted. If the submission is not interrupted by JavaScript, the "form
383 // submitted" event above will also be logged.
384 FORM_EVENT_SUGGESTION_SHOWN_WILL_SUBMIT_ONCE,
377 // An autofillable form is about to be submitted. If the submission is not 385 // An autofillable form is about to be submitted. If the submission is not
378 // interrupted by JavaScript, the "form submitted" events above will also be 386 // interrupted by JavaScript, the "form submitted" events above will also be
379 // logged. Depending on the user filling a local, server, masked server card 387 // logged. Depending on the user filling a local, server, masked server card
380 // or no suggestion one of the following will be triggered, at most once per 388 // or no suggestion one of the following will be triggered, at most once per
381 // page load. 389 // page load.
382 FORM_EVENT_NO_SUGGESTION_WILL_SUBMIT_ONCE, 390 FORM_EVENT_NO_SUGGESTION_WILL_SUBMIT_ONCE,
383 FORM_EVENT_LOCAL_SUGGESTION_WILL_SUBMIT_ONCE, 391 FORM_EVENT_LOCAL_SUGGESTION_WILL_SUBMIT_ONCE,
384 FORM_EVENT_SERVER_SUGGESTION_WILL_SUBMIT_ONCE, 392 FORM_EVENT_SERVER_SUGGESTION_WILL_SUBMIT_ONCE,
385 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_WILL_SUBMIT_ONCE, 393 FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_WILL_SUBMIT_ONCE,
386 394
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
707 FormFieldData last_polled_field_; 715 FormFieldData last_polled_field_;
708 }; 716 };
709 717
710 private: 718 private:
711 DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics); 719 DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics);
712 }; 720 };
713 721
714 } // namespace autofill 722 } // namespace autofill
715 723
716 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_ 724 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698