Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2575263002: [Autofill] Add a new metric for upstream. (Closed)
Patch Set: Added all the unit tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index d3adda5eaa01c43f7fbe153647ee9ebcf6c1fb70..51dd9c6a45afba92fcfc3470d43f76e413106555 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -76572,25 +76572,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="6" label="Local suggestion filled (once)"/>
<int value="7" label="Server suggestion filled (once)"/>
<int value="8" label="Masked server card suggestion filled (once)"/>
- <int value="9" label="Submitted with no suggestion filled (once)"/>
- <int value="10" label="Submitted with local suggestion filled (once)"/>
- <int value="11" label="Submitted with server suggestion filled (once)"/>
- <int value="12"
+ <int value="9" label="Submitted with suggestion shwon (once)"/>
Jared Saul 2016/12/15 21:30:26 Can these numbers actually change without affectin
Shanfeng 2016/12/15 21:59:03 One way to do this is to put the new data at the b
Jared Saul 2016/12/15 22:20:59 I don't mean changing more lines is a problem. I
+ <int value="10" label="Submitted with no suggestion filled (once)"/>
+ <int value="11" label="Submitted with local suggestion filled (once)"/>
+ <int value="12" label="Submitted with server suggestion filled (once)"/>
+ <int value="13"
label="Submitted with masked server card suggestion filled (once)"/>
- <int value="13" label="Masked server card suggestion selected">
+ <int value="14" label="Masked server card suggestion selected">
The user selected a masked server card that triggered an unmask attempt.
</int>
- <int value="14" label="Masked server card suggestion selected (once)">
+ <int value="15" label="Masked server card suggestion selected (once)">
The user selected a masked server card that triggered an unmask attempt at
least once.
</int>
- <int value="15"
+ <int value="16" label="About to be Submitted with suggestion shwon (once)"/>
Jared Saul 2016/12/15 21:30:26 s/shwon/shown
Jared Saul 2016/12/15 21:30:26 s/Submitted/submitted to be consistent
Shanfeng 2016/12/15 21:59:03 Done.
Shanfeng 2016/12/15 21:59:03 Done.
+ <int value="17"
label="About to be submitted with no suggestion filled (once)"/>
- <int value="16"
+ <int value="18"
label="About to be submitted with local suggestion filled (once)"/>
- <int value="17"
+ <int value="19"
label="About to be submitted with server suggestion filled (once)"/>
- <int value="18"
+ <int value="20"
label="About to be submitted with masked server card suggestion filled
(once)"/>
</enum>

Powered by Google App Engine
This is Rietveld 408576698