Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 25752007: Add SpellCheck.SpellingService.Enabled histogram. (Closed)

Created:
7 years, 2 months ago by dfaden
Modified:
7 years, 2 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, groby-ooo-7-16, rkaplow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add SpellCheck.SpellingService.Enabled histogram. Code to record stats for the SpellCheck.SpellingService.Enabled histogram was added in https://chromiumcodereview.appspot.com/12335019/. This CL adds the histogram to the main list of histograms so that other systems will pick it up. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226913

Patch Set 1 #

Total comments: 4

Patch Set 2 : corrections -> suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
groby-ooo-7-16
FWIW, LGTM from me - added isherman for OWNERs review. https://codereview.chromium.org/25752007/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/25752007/diff/1/tools/metrics/histograms/histograms.xml#newcode17360 ...
7 years, 2 months ago (2013-10-03 17:39:47 UTC) #1
dfaden
Thanks for the quick review! https://codereview.chromium.org/25752007/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/25752007/diff/1/tools/metrics/histograms/histograms.xml#newcode17360 tools/metrics/histograms/histograms.xml:17360: + Whether the user ...
7 years, 2 months ago (2013-10-03 17:59:15 UTC) #2
Ilya Sherman
LGTM
7 years, 2 months ago (2013-10-04 00:52:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfaden@google.com/25752007/7001
7 years, 2 months ago (2013-10-04 00:54:05 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 00:56:48 UTC) #5
Message was sent while issue was closed.
Change committed as 226913

Powered by Google App Engine
This is Rietveld 408576698