Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: extensions/renderer/api_binding_unittest.cc

Issue 2575173002: [Extensions Bindings] Add a bridge to use current custom bindings (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_binding_test.cc ('k') | extensions/renderer/api_bindings_system.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_binding_unittest.cc
diff --git a/extensions/renderer/api_binding_unittest.cc b/extensions/renderer/api_binding_unittest.cc
index 1476ff4d44a3394c4ee0942c43d24be10767ab7b..04c18065ebb5d52272faaadf1fb966adf2f75289 100644
--- a/extensions/renderer/api_binding_unittest.cc
+++ b/extensions/renderer/api_binding_unittest.cc
@@ -196,7 +196,7 @@ TEST_F(APIBindingUnittest, Test) {
APIBinding binding(
"test", *functions, nullptr, nullptr,
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
- nullptr, &refs);
+ base::MakeUnique<APIBindingHooks>(binding::RunJSFunction()), &refs);
EXPECT_TRUE(refs.empty());
v8::HandleScope handle_scope(isolate());
@@ -297,7 +297,7 @@ TEST_F(APIBindingUnittest, TypeRefsTest) {
APIBinding binding(
"test", *functions, types.get(), nullptr,
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
- nullptr, &refs);
+ base::MakeUnique<APIBindingHooks>(binding::RunJSFunction()), &refs);
EXPECT_EQ(2u, refs.size());
EXPECT_TRUE(base::ContainsKey(refs, "refObj"));
EXPECT_TRUE(base::ContainsKey(refs, "refEnum"));
@@ -343,7 +343,7 @@ TEST_F(APIBindingUnittest, RestrictedAPIs) {
APIBinding binding(
"test", *functions, nullptr, nullptr,
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
- nullptr, &refs);
+ base::MakeUnique<APIBindingHooks>(binding::RunJSFunction()), &refs);
v8::HandleScope handle_scope(isolate());
v8::Local<v8::Context> context = ContextLocal();
@@ -386,7 +386,7 @@ TEST_F(APIBindingUnittest, TestEventCreation) {
APIBinding binding(
"test", *functions, nullptr, events.get(),
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
- nullptr, &refs);
+ base::MakeUnique<APIBindingHooks>(binding::RunJSFunction()), &refs);
v8::HandleScope handle_scope(isolate());
v8::Local<v8::Context> context = ContextLocal();
@@ -422,7 +422,7 @@ TEST_F(APIBindingUnittest, TestDisposedContext) {
APIBinding binding(
"test", *functions, nullptr, nullptr,
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
- nullptr, &refs);
+ base::MakeUnique<APIBindingHooks>(binding::RunJSFunction()), &refs);
EXPECT_TRUE(refs.empty());
v8::HandleScope handle_scope(isolate());
« no previous file with comments | « extensions/renderer/api_binding_test.cc ('k') | extensions/renderer/api_bindings_system.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698