Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: extensions/renderer/api_binding_test.cc

Issue 2575173002: [Extensions Bindings] Add a bridge to use current custom bindings (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_binding_test.h ('k') | extensions/renderer/api_binding_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_binding_test.cc
diff --git a/extensions/renderer/api_binding_test.cc b/extensions/renderer/api_binding_test.cc
index a6588b910f1ef4b5daa76e89266a0944af2a0f77..9312a34f6d817bbdb19cbf63cd8f099b04aabc96 100644
--- a/extensions/renderer/api_binding_test.cc
+++ b/extensions/renderer/api_binding_test.cc
@@ -15,6 +15,10 @@ namespace extensions {
APIBindingTest::APIBindingTest() {}
APIBindingTest::~APIBindingTest() {}
+v8::ExtensionConfiguration* APIBindingTest::GetV8ExtensionConfiguration() {
+ return nullptr;
+}
+
void APIBindingTest::SetUp() {
// Much of this initialization is stolen from the somewhat-similar
// gin::V8Test.
@@ -31,7 +35,8 @@ void APIBindingTest::SetUp() {
isolate()->Enter();
v8::HandleScope handle_scope(isolate());
- v8::Local<v8::Context> context = v8::Context::New(isolate());
+ v8::Local<v8::Context> context =
+ v8::Context::New(isolate(), GetV8ExtensionConfiguration());
context->Enter();
context_holder_ = base::MakeUnique<gin::ContextHolder>(isolate());
context_holder_->SetContext(context);
« no previous file with comments | « extensions/renderer/api_binding_test.h ('k') | extensions/renderer/api_binding_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698