extensions/renderer/api_request_handler.cc - Issue 2575173002: [Extensions Bindings] Add a bridge to use current custom bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_request_handler.cc

Issue 2575173002: [Extensions Bindings] Add a bridge to use current custom bindings (Closed)

Patch Set: jbroman II Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/api_request_handler.cc

diff --git a/extensions/renderer/api_request_handler.cc b/extensions/renderer/api_request_handler.cc

index e23e33bc3d1a07070fc23ac78df8399df708d94d..3b31cd979dea38699621ef8478a596b6da97d4f1 100644

--- a/extensions/renderer/api_request_handler.cc

+++ b/extensions/renderer/api_request_handler.cc

@@ -55,6 +55,7 @@ void APIRequestHandler::CompleteRequest(int request_id,

pending_requests_.erase(iter);

v8::Isolate* isolate = pending_request.isolate;

+ v8::HandleScope handle_scope(isolate);

v8::Local<v8::Context> context = pending_request.context.Get(isolate);

std::unique_ptr<content::V8ValueConverter> converter(

content::V8ValueConverter::create());