Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: extensions/renderer/api_binding_bridge.h

Issue 2575173002: [Extensions Bindings] Add a bridge to use current custom bindings (Closed)
Patch Set: update test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_binding_bridge.h
diff --git a/extensions/renderer/api_binding_bridge.h b/extensions/renderer/api_binding_bridge.h
new file mode 100644
index 0000000000000000000000000000000000000000..e5c855958583f4718f6f7243f2d91d595942ee5c
--- /dev/null
+++ b/extensions/renderer/api_binding_bridge.h
@@ -0,0 +1,55 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_RENDERER_API_BINDING_BRIDGE_H_
+#define EXTENSIONS_RENDERER_API_BINDING_BRIDGE_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "extensions/renderer/api_binding_types.h"
+#include "gin/wrappable.h"
+#include "v8/include/v8.h"
+
+namespace extensions {
+
+// An object that serves as a bridge between the current JS-centric bindings and
+// the new native bindings system. This basically needs to conform to the public
+// methods of the Binding prototype in binding.js.
+class APIBindingBridge final : public gin::Wrappable<APIBindingBridge> {
+ public:
+ APIBindingBridge(v8::Local<v8::Context> context,
+ v8::Local<v8::Value> api_object,
+ v8::Local<v8::Value> js_hook_interface,
+ const std::string& extension_id,
+ const std::string& context_type,
+ const binding::RunJSFunction& run_js);
+ ~APIBindingBridge() override;
+
+ static gin::WrapperInfo kWrapperInfo;
+
+ // gin::Wrappable:
+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
+ v8::Isolate* isolate) final;
+
+ private:
+ // Runs the given function and registers custom hooks.
+ void RegisterCustomHook(v8::Isolate* isolate,
+ v8::Local<v8::Function> function);
jbroman 2016/12/20 20:51:35 I assume it's documented elsewhere what parameters
Devlin 2016/12/20 22:20:19 Added more of a comment.
+
+ // The id of the extension that owns the context this belongs to.
+ std::string extension_id_;
+
+ // The type of context this belongs to.
+ std::string context_type_;
+
+ // A function to run JS safely.
+ binding::RunJSFunction run_js_;
+
+ DISALLOW_COPY_AND_ASSIGN(APIBindingBridge);
+};
+
+} // namespace extensions
+
+#endif // EXTENSIONS_RENDERER_API_BINDING_BRIDGE_H_

Powered by Google App Engine
This is Rietveld 408576698