Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: extensions/renderer/argument_spec.cc

Issue 2575173002: [Extensions Bindings] Add a bridge to use current custom bindings (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/argument_spec.cc
diff --git a/extensions/renderer/argument_spec.cc b/extensions/renderer/argument_spec.cc
index f79ea8a9107f44cd2d1da2e4a275ba82ba7cac67..50b91a7217e3a7e45b7f9aed37157424e0efc28b 100644
--- a/extensions/renderer/argument_spec.cc
+++ b/extensions/renderer/argument_spec.cc
@@ -47,6 +47,15 @@ void ArgumentSpec::InitializeType(const base::DictionaryValue* dict) {
return;
}
+ {
+ const base::ListValue* choices = nullptr;
Devlin 2016/12/16 01:55:49 This is needed for the chrome.test API to work, bu
+ if (dict->GetList("choices", &choices)) {
+ // TODO(devlin): Properly handle choices.
+ type_ = ArgumentType::ANY;
+ return;
+ }
+ }
+
std::string type_string;
CHECK(dict->GetString("type", &type_string));
if (type_string == "integer")

Powered by Google App Engine
This is Rietveld 408576698