Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: extensions/renderer/api_bindings_system_unittest.cc

Issue 2575173002: [Extensions Bindings] Add a bridge to use current custom bindings (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_bindings_system_unittest.cc
diff --git a/extensions/renderer/api_bindings_system_unittest.cc b/extensions/renderer/api_bindings_system_unittest.cc
index f59f4261f48319fade8fb210a422569e7229f3ba..23d035d28572028f06eb1f8e0bdba1650ffd1bba 100644
--- a/extensions/renderer/api_bindings_system_unittest.cc
+++ b/extensions/renderer/api_bindings_system_unittest.cc
@@ -210,10 +210,10 @@ TEST_F(APIBindingsSystemTest, TestInitializationAndCallbacks) {
v8::Local<v8::Context> context = ContextLocal();
v8::Local<v8::Object> alpha_api = bindings_system()->CreateAPIInstance(
- kAlphaAPIName, context, isolate(), base::Bind(&AllowAllAPIs));
+ kAlphaAPIName, context, isolate(), base::Bind(&AllowAllAPIs), nullptr);
ASSERT_FALSE(alpha_api.IsEmpty());
v8::Local<v8::Object> beta_api = bindings_system()->CreateAPIInstance(
- kBetaAPIName, context, isolate(), base::Bind(&AllowAllAPIs));
+ kBetaAPIName, context, isolate(), base::Bind(&AllowAllAPIs), nullptr);
ASSERT_FALSE(beta_api.IsEmpty());
{
@@ -321,7 +321,7 @@ TEST_F(APIBindingsSystemTest, TestCustomHooks) {
base::Bind(hook, &did_call));
v8::Local<v8::Object> alpha_api = bindings_system()->CreateAPIInstance(
- kAlphaAPIName, context, isolate(), base::Bind(&AllowAllAPIs));
+ kAlphaAPIName, context, isolate(), base::Bind(&AllowAllAPIs), nullptr);
ASSERT_FALSE(alpha_api.IsEmpty());
{
@@ -408,7 +408,8 @@ TEST_F(APIBindingsSystemTestWithRealAPI, RealAPIs) {
auto add_api_to_chrome = [this, &chrome,
&context](const std::string& api_name) {
v8::Local<v8::Object> api = bindings_system()->CreateAPIInstance(
- api_name, context, context->GetIsolate(), base::Bind(&AllowAllAPIs));
+ api_name, context, context->GetIsolate(), base::Bind(&AllowAllAPIs),
+ nullptr);
ASSERT_FALSE(api.IsEmpty()) << api_name;
v8::Maybe<bool> res = chrome->Set(
context, gin::StringToV8(context->GetIsolate(), api_name), api);

Powered by Google App Engine
This is Rietveld 408576698