Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: extensions/renderer/api_binding_bridge.cc

Issue 2575173002: [Extensions Bindings] Add a bridge to use current custom bindings (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_binding_bridge.cc
diff --git a/extensions/renderer/api_binding_bridge.cc b/extensions/renderer/api_binding_bridge.cc
new file mode 100644
index 0000000000000000000000000000000000000000..048889f1c446c19bfa854b1772a9d0c4f365300c
--- /dev/null
+++ b/extensions/renderer/api_binding_bridge.cc
@@ -0,0 +1,67 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/renderer/api_binding_bridge.h"
+
+#include "gin/converter.h"
+#include "gin/object_template_builder.h"
+
+namespace extensions {
+
+gin::WrapperInfo APIBindingBridge::kWrapperInfo = {gin::kEmbedderNativeGin};
+
+APIBindingBridge::APIBindingBridge(v8::Global<v8::Value> api_object,
+ v8::Global<v8::Value> js_hooks_interface,
+ const std::string& extension_id,
+ const std::string& context_type,
+ const binding::RunJSFunction& run_js)
+ : api_object_(std::move(api_object)),
+ js_hooks_interface_(std::move(js_hooks_interface)),
+ extension_id_(extension_id),
+ context_type_(context_type),
+ run_js_(run_js) {}
+
+APIBindingBridge::~APIBindingBridge() {}
+
+gin::ObjectTemplateBuilder APIBindingBridge::GetObjectTemplateBuilder(
+ v8::Isolate* isolate) {
+ return Wrappable<APIBindingBridge>::GetObjectTemplateBuilder(isolate)
+ .SetMethod("registerCustomHook", &APIBindingBridge::RegisterCustomHook);
+}
+
+void APIBindingBridge::RegisterCustomHook(v8::Isolate* isolate,
+ v8::Local<v8::Function> function) {
+ // The object and arguments here are meant to match those passed to the hook
+ // functions in binding.js.
+ v8::Local<v8::Context> context = isolate->GetCallingContext();
jbroman 2016/12/16 19:00:49 GetCallingContext is deprecated; did you want GetC
Devlin 2016/12/16 20:31:17 Done.
+ v8::Local<v8::Object> hook_object = v8::Object::New(isolate);
+ v8::Maybe<bool> result = hook_object->CreateDataProperty(
+ context, gin::StringToSymbol(isolate, "apiFunctions"),
+ js_hooks_interface_.Get(isolate));
+ if (!result.IsJust() || !result.FromJust())
+ return;
+
+ result = hook_object->CreateDataProperty(
+ context, gin::StringToSymbol(isolate, "compiledApi"),
+ api_object_.Get(isolate));
+ if (!result.IsJust() || !result.FromJust())
+ return;
+
+ // TODO(devlin): The binding.js version of these hooks also has a 'schema'
+ // property. I wonder if we can factor that out? If not, we'll need to add it
+ // here.
+
+ result = hook_object->SetPrototype(context, v8::Null(isolate));
+ if (!result.IsJust() || !result.FromJust())
+ return;
+
+ v8::Local<v8::String> extension_id =
+ gin::StringToSymbol(isolate, extension_id_);
+ v8::Local<v8::String> context_type =
+ gin::StringToSymbol(isolate, context_type_);
+ v8::Local<v8::Value> args[] = {hook_object, extension_id, context_type};
+ run_js_.Run(function, context, arraysize(args), args);
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698