Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 257513002: Add synonyms for collection types over MutationObserver-related types. (Closed)

Created:
6 years, 8 months ago by sof
Modified:
6 years, 8 months ago
CC:
blink-reviews, chrishtr, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, ojan, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add synonyms for collection types over MutationObserver-related types. With r172148, the MutationObserver collection types got even bulkier. Tidy up and shorten by adding some typedefs. R=haraken@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M Source/core/dom/MutationObserver.h View 3 chunks +8 lines, -2 lines 0 comments Download
M Source/core/dom/MutationObserver.cpp View 8 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look. (If these typedefs hide representation details that are better not left ...
6 years, 8 months ago (2014-04-24 07:12:29 UTC) #1
haraken
LGTM
6 years, 8 months ago (2014-04-24 07:52:31 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-24 08:29:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/257513002/1
6 years, 8 months ago (2014-04-24 08:30:00 UTC) #4
Mads Ager (chromium)
lgtm2
6 years, 8 months ago (2014-04-24 09:09:36 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 09:41:05 UTC) #6
Message was sent while issue was closed.
Change committed as 172475

Powered by Google App Engine
This is Rietveld 408576698