Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2526)

Unified Diff: chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc

Issue 257493004: [fsp] Refactor handling operations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc
diff --git a/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc b/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc
index 8503b6898de476874d2de66755c849e4751b9b72..aa98bc99ae3656b269ee74d77ef80a0978bfd278 100644
--- a/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc
+++ b/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc
@@ -102,9 +102,8 @@ class FileSystemProviderProvidedFileSystemTest : public testing::Test {
TEST_F(FileSystemProviderProvidedFileSystemTest, RequestUnmount_Success) {
EventLogger logger;
- bool result = provided_file_system_->RequestUnmount(
+ provided_file_system_->RequestUnmount(
base::Bind(&EventLogger::OnStatusCallback, logger.GetWeakPtr()));
- ASSERT_TRUE(result);
base::RunLoop().RunUntilIdle();
// Verify that the event has been sent to the providing extension.
@@ -129,7 +128,7 @@ TEST_F(FileSystemProviderProvidedFileSystemTest, RequestUnmount_Success) {
// Simulate sending a success response from the providing extension.
RequestManager* request_manager = provided_file_system_->GetRequestManager();
ASSERT_TRUE(request_manager);
- scoped_ptr<base::DictionaryValue> response(new base::DictionaryValue());
+ scoped_ptr<RequestValue> response;
bool reply_result = request_manager->FulfillRequest(
request_id, response.Pass(), false /* has_next */);
EXPECT_TRUE(reply_result);
@@ -142,9 +141,8 @@ TEST_F(FileSystemProviderProvidedFileSystemTest, RequestUnmount_Success) {
TEST_F(FileSystemProviderProvidedFileSystemTest, RequestUnmount_Error) {
EventLogger logger;
- bool result = provided_file_system_->RequestUnmount(
+ provided_file_system_->RequestUnmount(
base::Bind(&EventLogger::OnStatusCallback, logger.GetWeakPtr()));
- ASSERT_TRUE(result);
base::RunLoop().RunUntilIdle();
// Verify that the event has been sent to the providing extension.

Powered by Google App Engine
This is Rietveld 408576698