Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/chromeos/file_system_provider/service.cc

Issue 257493004: [fsp] Refactor handling operations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed tests. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/file_system_provider/request_value.cc ('k') | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_system_provider/service.cc
diff --git a/chrome/browser/chromeos/file_system_provider/service.cc b/chrome/browser/chromeos/file_system_provider/service.cc
index 36bdda0063284813622296953f2129446cca7003..35d5bcb984b5edc283ecdde69f809b06e8fbbbe4 100644
--- a/chrome/browser/chromeos/file_system_provider/service.cc
+++ b/chrome/browser/chromeos/file_system_provider/service.cc
@@ -47,6 +47,8 @@ Service::Service(Profile* profile,
}
Service::~Service() {
+ extension_registry_->RemoveObserver(this);
+
ProvidedFileSystemMap::iterator it = file_system_map_.begin();
while (it != file_system_map_.end()) {
const int file_system_id = it->first;
@@ -204,10 +206,11 @@ bool Service::RequestUnmount(int file_system_id) {
if (file_system_it == file_system_map_.end())
return false;
- return file_system_it->second->RequestUnmount(
+ file_system_it->second->RequestUnmount(
base::Bind(&Service::OnRequestUnmountStatus,
weak_ptr_factory_.GetWeakPtr(),
file_system_it->second->GetFileSystemInfo()));
+ return true;
}
std::vector<ProvidedFileSystemInfo> Service::GetProvidedFileSystemInfoList() {
« no previous file with comments | « chrome/browser/chromeos/file_system_provider/request_value.cc ('k') | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698