[fsp] Refactor handling operations.

chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h"
 
 #include <string>
 
 #include "base/values.h"
 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h"
 #include "chrome/browser/chromeos/file_system_provider/request_manager.h"
+#include "chrome/browser/chromeos/file_system_provider/request_value.h"
 #include "chrome/browser/chromeos/file_system_provider/service.h"
 #include "chrome/common/extensions/api/file_system_provider.h"
 #include "chrome/common/extensions/api/file_system_provider_internal.h"
 
 using chromeos::file_system_provider::ProvidedFileSystemInterface;
 using chromeos::file_system_provider::RequestManager;
+using chromeos::file_system_provider::RequestValue;
 using chromeos::file_system_provider::Service;
 
 namespace extensions {
 namespace {
 
 // Error names from
 // http://www.w3.org/TR/file-system-api/#errors-and-exceptions
 const char kNotFoundErrorName[] = "NotFoundError";
 const char kSecurityErrorName[] = "SecurityError";
 
@@ skipping 116 matching lines @@
     return false;
   }
 
   base::ListValue* result = new base::ListValue();
   SetResult(result);
   return true;
 }
 
 bool FileSystemProviderInternalUnmountRequestedSuccessFunction::RunImpl() {
   using api::file_system_provider_internal::UnmountRequestedSuccess::Params;
-  const scoped_ptr<Params> params(Params::Create(*args_));
+  scoped_ptr<Params> params(Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   Service* service = Service::Get(GetProfile());
   DCHECK(service);
 
   ProvidedFileSystemInterface* file_system =
       service->GetProvidedFileSystem(extension_id(), params->file_system_id);
   if (!file_system) {
     base::ListValue* result = new base::ListValue();
     result->Append(
         CreateError(kNotFoundErrorName, kResponseFailedErrorMessage));
     SetResult(result);
     return false;
   }
 
   RequestManager* request_manager = file_system->GetRequestManager();
   DCHECK(request_manager);
 
-  if (!request_manager->FulfillRequest(params->request_id,
-                                       scoped_ptr<base::DictionaryValue>(),
-                                       false /* has_more */)) {
+  const int request_id = params->request_id;
+  if (!request_manager->FulfillRequest(
+          request_id,
+          make_scoped_ptr(RequestValue::CreateForUnmountSuccess(params.Pass())),
+          false /* has_more */)) {
     // TODO(mtomasz): Pass more detailed errors, rather than just a bool.
     base::ListValue* result = new base::ListValue();
     result->Append(
         CreateError(kSecurityErrorName, kResponseFailedErrorMessage));
     SetResult(result);
     return false;
   }
 
   base::ListValue* result = new base::ListValue();
   SetResult(result);
   return true;
 }
 
 bool FileSystemProviderInternalUnmountRequestedErrorFunction::RunImpl() {
   using api::file_system_provider_internal::UnmountRequestedError::Params;
-  const scoped_ptr<Params> params(Params::Create(*args_));
+  scoped_ptr<Params> params(Params::Create(*args_));

[kinaba, 2014/04/25 06:35:06]

nit: The changes for this function looks unneccessary.

[mtomasz, 2014/04/28 00:42:47]

Done.

   EXTENSION_FUNCTION_VALIDATE(params);
 
   Service* service = Service::Get(GetProfile());
   DCHECK(service);
 
   ProvidedFileSystemInterface* file_system =
       service->GetProvidedFileSystem(extension_id(), params->file_system_id);
   if (!file_system) {
     base::ListValue* result = new base::ListValue();
     result->Append(
         CreateError(kNotFoundErrorName, kResponseFailedErrorMessage));
     SetResult(result);
     return false;
   }
 
   RequestManager* request_manager = file_system->GetRequestManager();
   DCHECK(request_manager);
 
+  const int request_id = params->request_id;
   if (!request_manager->RejectRequest(
-          params->request_id, ProviderErrorToFileError(params->error))) {
+          request_id, ProviderErrorToFileError(params->error))) {
     // TODO(mtomasz): Pass more detailed errors, rather than just a bool.
     base::ListValue* result = new base::ListValue();
     result->Append(
         CreateError(kSecurityErrorName, kResponseFailedErrorMessage));
     SetResult(result);
     return false;
   }
 
   base::ListValue* result = new base::ListValue();
   SetResult(result);
   return true;
 }
 
 }  // namespace extensions