[fsp] Refactor handling operations.

chrome/browser/chromeos/file_system_provider/request_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_system_provider/request_manager.h"
 
 #include "base/files/file.h"
 #include "base/stl_util.h"
-#include "base/values.h"
 
 namespace chromeos {
 namespace file_system_provider {
 
 namespace {
 
 // Timeout in seconds, before a request is considered as stale and hence
 // aborted.
 const int kDefaultTimeout = 10;
 
@@ skipping 10 matching lines @@
   while (it != requests_.end()) {
     const int request_id = it->first;
     ++it;
     RejectRequest(request_id, base::File::FILE_ERROR_ABORT);
   }
 
   DCHECK_EQ(0u, requests_.size());
   STLDeleteValues(&requests_);
 }
 
-int RequestManager::CreateRequest(const SuccessCallback& success_callback,
-                                  const ErrorCallback& error_callback) {
+int RequestManager::CreateRequest(scoped_ptr<HandlerInterface> handler) {
   // The request id is unique per request manager, so per service, thereof
   // per profile.
   int request_id = next_id_++;
 
   // If cycled the int, then signal an error.
   if (requests_.find(request_id) != requests_.end())
     return 0;
 
   Request* request = new Request;
-  request->success_callback = success_callback;
-  request->error_callback = error_callback;
+  request->handler = handler.Pass();
   request->timeout_timer.Start(FROM_HERE,
                                timeout_,
                                base::Bind(&RequestManager::OnRequestTimeout,
                                           weak_ptr_factory_.GetWeakPtr(),
                                           request_id));
   requests_[request_id] = request;
 
+  // Execute the request implementation. In case of an execution failure,
+  // unregister and return 0. This may often happen, eg. if the providing
+  // extension is not listening for the request event being sent.
+  // In such case, there is no reason we should abort as soon as possible.
+  if (!request->handler->Execute(request_id)) {
+    delete request;
+    requests_.erase(request_id);
+    return 0;
+  }
+
   return request_id;
 }
 
 bool RequestManager::FulfillRequest(int request_id,
-                                    scoped_ptr<base::DictionaryValue> response,
+                                    scoped_ptr<RequestValue> response,
                                     bool has_next) {
   RequestMap::iterator request_it = requests_.find(request_id);
 
   if (request_it == requests_.end())
     return false;
 
-  if (!request_it->second->success_callback.is_null())
-    request_it->second->success_callback.Run(response.Pass(), has_next);
+  request_it->second->handler->OnSuccess(request_id, response.Pass(), has_next);
   if (!has_next) {
     delete request_it->second;
     requests_.erase(request_it);
   } else {
     request_it->second->timeout_timer.Reset();
   }
 
   return true;
 }
 
 bool RequestManager::RejectRequest(int request_id, base::File::Error error) {
   RequestMap::iterator request_it = requests_.find(request_id);
 
   if (request_it == requests_.end())
     return false;
 
-  if (!request_it->second->error_callback.is_null())
-    request_it->second->error_callback.Run(error);
+  request_it->second->handler->OnError(request_id, error);
   delete request_it->second;
   requests_.erase(request_it);
 
   return true;
 }
 
 void RequestManager::SetTimeoutForTests(const base::TimeDelta& timeout) {
   timeout_ = timeout;
 }
 
 void RequestManager::OnRequestTimeout(int request_id) {
   RejectRequest(request_id, base::File::FILE_ERROR_ABORT);
 }
 
 RequestManager::Request::Request() {}
 
 RequestManager::Request::~Request() {}
 
 }  // namespace file_system_provider
 }  // namespace chromeos