Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: third_party/WebKit/LayoutTests/inspector/components/widget-focus.html

Issue 2574823002: DevTools: do not make main panel unconditionally focused by default. (Closed)
Patch Set: fixed the test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/components/widget-focus-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/components/widget-focus.html
diff --git a/third_party/WebKit/LayoutTests/inspector/components/widget-focus.html b/third_party/WebKit/LayoutTests/inspector/components/widget-focus.html
index d3349010fd0d9b9858c16510d64057fe0d525804..b02be9ebf011e8530b05e9bffbb764f3b1e99153 100644
--- a/third_party/WebKit/LayoutTests/inspector/components/widget-focus.html
+++ b/third_party/WebKit/LayoutTests/inspector/components/widget-focus.html
@@ -6,6 +6,17 @@
function test()
{
var outerInput = document.createElement("input");
+ outerInput.id = "Outer"
+
+ var input1 = document.createElement("input");
+ input1.id = "Input1";
+ var input2 = document.createElement("input");
+ input2.id = "Input2";
+ var input3 = document.createElement("input");
+ input3.id = "Input3";
+ var input4 = document.createElement("input");
+ input4.id = "Input4";
+
UI.inspectorView.element.appendChild(outerInput);
var mainWidget = new UI.Widget();
@@ -13,61 +24,66 @@ function test()
var widget1 = new UI.Widget();
widget1.show(mainWidget.element);
- var input1 = document.createElement("input");
- input1.id = "input1";
widget1.element.appendChild(input1);
widget1.setDefaultFocusedElement(input1);
var widget2 = new UI.Widget();
widget2.show(mainWidget.element);
- var input2 = document.createElement("input");
- input2.id = "input2";
widget2.element.appendChild(input2);
widget2.setDefaultFocusedElement(input2);
+ InspectorTest.addResult("Focusing outer input...");
outerInput.focus();
dumpFocus();
+ InspectorTest.addResult("Focusing widget1...");
widget1.focus();
dumpFocus();
+ InspectorTest.addResult("Focusing widget2...");
input2.focus();
dumpFocus();
+ InspectorTest.addResult("Focusing outer input again...");
outerInput.focus();
dumpFocus();
+ InspectorTest.addResult("Focusing main widget...");
mainWidget.focus();
dumpFocus();
+ InspectorTest.addResult("Focusing outer input again...");
outerInput.focus();
dumpFocus();
+ InspectorTest.addResult("Hiding widget2 and focusing main widget...");
widget2.hideWidget();
mainWidget.focus();
dumpFocus();
var splitWidget = new UI.SplitWidget();
splitWidget.show(mainWidget.element);
+
var widget3 = new UI.Widget();
- var input3 = document.createElement("input");
- input1.id = "input3";
widget3.element.appendChild(input3);
widget3.setDefaultFocusedElement(input3);
splitWidget.setSidebarWidget(widget3);
+
var widget4 = new UI.Widget();
- var input4 = document.createElement("input");
- input4.id = "input4";
widget4.element.appendChild(input4);
widget4.setDefaultFocusedElement(input4);
splitWidget.setMainWidget(widget4);
+ splitWidget.setDefaultFocusedChild(widget4);
+ InspectorTest.addResult("Focusing split widget in main that has 3 and 4 inputs...");
splitWidget.focus();
dumpFocus();
+ InspectorTest.addResult("Focusing widget 3...");
widget3.focus();
dumpFocus();
+ InspectorTest.addResult("Focusing main widget again...");
mainWidget.focus();
dumpFocus();
@@ -76,19 +92,8 @@ function test()
function dumpFocus()
{
var focused = document.deepActiveElement();
- if (focused === outerInput) {
- InspectorTest.addResult("Outer Focused");
- } else if (focused === input1) {
- InspectorTest.addResult("Input1 Focused");
- } else if (focused === input2) {
- InspectorTest.addResult("Input2 Focused");
- } else if (focused === input3) {
- InspectorTest.addResult("Input3 Focused");
- } else if (focused === input4) {
- InspectorTest.addResult("Input4 Focused");
- } else {
- InspectorTest.addResult("No focus");
- }
+ var id = focused ? focused.id : "";
+ InspectorTest.addResult(id ? id + " Focused" : "No focus");
}
}
</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/components/widget-focus-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698