Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js

Issue 2574823002: DevTools: do not make main panel unconditionally focused by default. (Closed)
Patch Set: fixed the test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @implements {Common.App} 5 * @implements {Common.App}
6 * @unrestricted 6 * @unrestricted
7 */ 7 */
8 Emulation.AdvancedApp = class { 8 Emulation.AdvancedApp = class {
9 constructor() { 9 constructor() {
10 Components.dockController.addEventListener( 10 Components.dockController.addEventListener(
(...skipping 11 matching lines...) Expand all
22 22
23 /** 23 /**
24 * @override 24 * @override
25 * @param {!Document} document 25 * @param {!Document} document
26 */ 26 */
27 presentUI(document) { 27 presentUI(document) {
28 var rootView = new UI.RootView(); 28 var rootView = new UI.RootView();
29 29
30 this._rootSplitWidget = new UI.SplitWidget(false, true, 'InspectorView.split ViewState', 555, 300, true); 30 this._rootSplitWidget = new UI.SplitWidget(false, true, 'InspectorView.split ViewState', 555, 300, true);
31 this._rootSplitWidget.show(rootView.element); 31 this._rootSplitWidget.show(rootView.element);
32
33 this._rootSplitWidget.setSidebarWidget(UI.inspectorView); 32 this._rootSplitWidget.setSidebarWidget(UI.inspectorView);
33 this._rootSplitWidget.setDefaultFocusedChild(UI.inspectorView);
34 UI.inspectorView.setOwnerSplit(this._rootSplitWidget); 34 UI.inspectorView.setOwnerSplit(this._rootSplitWidget);
35 35
36 this._inspectedPagePlaceholder = new Emulation.InspectedPagePlaceholder(); 36 this._inspectedPagePlaceholder = new Emulation.InspectedPagePlaceholder();
37 this._inspectedPagePlaceholder.addEventListener( 37 this._inspectedPagePlaceholder.addEventListener(
38 Emulation.InspectedPagePlaceholder.Events.Update, this._onSetInspectedPa geBounds.bind(this), this); 38 Emulation.InspectedPagePlaceholder.Events.Update, this._onSetInspectedPa geBounds.bind(this), this);
39 this._deviceModeView = new Emulation.DeviceModeWrapper(this._inspectedPagePl aceholder); 39 this._deviceModeView = new Emulation.DeviceModeWrapper(this._inspectedPagePl aceholder);
40 40
41 Components.dockController.addEventListener( 41 Components.dockController.addEventListener(
42 Components.DockController.Events.BeforeDockSideChanged, this._onBeforeDo ckSideChange, this); 42 Components.DockController.Events.BeforeDockSideChanged, this._onBeforeDo ckSideChange, this);
43 Components.dockController.addEventListener( 43 Components.dockController.addEventListener(
44 Components.DockController.Events.DockSideChanged, this._onDockSideChange , this); 44 Components.DockController.Events.DockSideChanged, this._onDockSideChange , this);
45 Components.dockController.addEventListener( 45 Components.dockController.addEventListener(
46 Components.DockController.Events.AfterDockSideChanged, this._onAfterDock SideChange, this); 46 Components.DockController.Events.AfterDockSideChanged, this._onAfterDock SideChange, this);
47 this._onDockSideChange(); 47 this._onDockSideChange();
48 48
49 console.timeStamp('AdvancedApp.attachToBody'); 49 console.timeStamp('AdvancedApp.attachToBody');
50 rootView.attachToDocument(document); 50 rootView.attachToDocument(document);
51 rootView.focus();
51 this._inspectedPagePlaceholder.update(); 52 this._inspectedPagePlaceholder.update();
52 } 53 }
53 54
54 /** 55 /**
55 * @param {!Common.Event} event 56 * @param {!Common.Event} event
56 */ 57 */
57 _openToolboxWindow(event) { 58 _openToolboxWindow(event) {
58 if (/** @type {string} */ (event.data.to) !== Components.DockController.Stat e.Undocked) 59 if (/** @type {string} */ (event.data.to) !== Components.DockController.Stat e.Undocked)
59 return; 60 return;
60 61
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 */ 186 */
186 Emulation.AdvancedAppProvider = class { 187 Emulation.AdvancedAppProvider = class {
187 /** 188 /**
188 * @override 189 * @override
189 * @return {!Common.App} 190 * @return {!Common.App}
190 */ 191 */
191 createApp() { 192 createApp() {
192 return Emulation.AdvancedApp._instance(); 193 return Emulation.AdvancedApp._instance();
193 } 194 }
194 }; 195 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698