Chromium Code Reviews| Index: test/inspector/task-runner.h |
| diff --git a/test/inspector/task-runner.h b/test/inspector/task-runner.h |
| index 17385468bed7529b663ed317184e474f352c8a41..045bba0d259513ec9e36f891ff083723808817e0 100644 |
| --- a/test/inspector/task-runner.h |
| +++ b/test/inspector/task-runner.h |
| @@ -67,18 +67,33 @@ class TaskRunner : public v8::base::Thread { |
| DISALLOW_COPY_AND_ASSIGN(TaskRunner); |
| }; |
| -class ExecuteStringTask : public TaskRunner::Task { |
| +class AsyncTask : public TaskRunner::Task { |
| + public: |
| + AsyncTask(const char* task_name, v8_inspector::V8Inspector* inspector); |
|
dgozman
2016/12/13 18:33:24
Looks strange now to pass both inspector here and
kozy
2016/12/13 19:15:27
Agreed.
|
| + virtual ~AsyncTask() = default; |
| + |
| + void Run(v8::Isolate* isolate, |
| + const v8::Global<v8::Context>& context) override; |
| + virtual void AsyncRun(v8::Isolate* isolate, |
| + const v8::Global<v8::Context>& context) = 0; |
| + |
| + private: |
| + v8_inspector::V8Inspector* inspector_; |
| +}; |
| + |
| +class ExecuteStringTask : public AsyncTask { |
| public: |
| ExecuteStringTask(const v8::internal::Vector<uint16_t>& expression, |
| v8::Local<v8::String> name, |
| v8::Local<v8::Integer> line_offset, |
| - v8::Local<v8::Integer> column_offset); |
| + v8::Local<v8::Integer> column_offset, const char* task_name, |
| + v8_inspector::V8Inspector* inspector); |
| explicit ExecuteStringTask( |
| const v8::internal::Vector<const char>& expression); |
| bool is_inspector_task() override { return false; } |
| - void Run(v8::Isolate* isolate, |
| - const v8::Global<v8::Context>& context) override; |
| + void AsyncRun(v8::Isolate* isolate, |
| + const v8::Global<v8::Context>& context) override; |
| private: |
| v8::internal::Vector<uint16_t> expression_; |