Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: test/inspector/task-runner.cc

Issue 2574803002: [inspector] add async instrumentation for setTimeout in tests (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/inspector/inspector-test.cc ('K') | « test/inspector/task-runner.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/inspector/task-runner.cc
diff --git a/test/inspector/task-runner.cc b/test/inspector/task-runner.cc
index 51fd11020324ebc3d5f0e143becf5576b654bf71..9ca40fa5fd34b829f00bc55f8b47cf3b7a651210 100644
--- a/test/inspector/task-runner.cc
+++ b/test/inspector/task-runner.cc
@@ -4,6 +4,8 @@
#include "test/inspector/task-runner.h"
+#include "test/inspector/inspector-impl.h"
+
#if !defined(_WIN32) && !defined(_WIN64)
#include <unistd.h> // NOLINT
#endif // !defined(_WIN32) && !defined(_WIN64)
@@ -137,15 +139,19 @@ v8::internal::Vector<uint16_t> ToVector(v8::Local<v8::String> str) {
ExecuteStringTask::ExecuteStringTask(
const v8::internal::Vector<uint16_t>& expression,
v8::Local<v8::String> name, v8::Local<v8::Integer> line_offset,
- v8::Local<v8::Integer> column_offset)
+ v8::Local<v8::Integer> column_offset, bool report_async)
: expression_(expression),
name_(ToVector(name)),
line_offset_(line_offset.As<v8::Int32>()->Value()),
- column_offset_(column_offset.As<v8::Int32>()->Value()) {}
+ column_offset_(column_offset.As<v8::Int32>()->Value()),
+ report_async_(report_async) {}
ExecuteStringTask::ExecuteStringTask(
const v8::internal::Vector<const char>& expression)
- : expression_utf8_(expression), line_offset_(0), column_offset_(0) {}
+ : expression_utf8_(expression),
+ line_offset_(0),
+ column_offset_(0),
+ report_async_(false) {}
void ExecuteStringTask::Run(v8::Isolate* isolate,
const v8::Global<v8::Context>& context) {
@@ -183,5 +189,10 @@ void ExecuteStringTask::Run(v8::Isolate* isolate,
.ToLocal(&script))
return;
v8::MaybeLocal<v8::Value> result;
+ v8_inspector::V8Inspector* inspector =
+ report_async_ ? InspectorClientImpl::InspectorFromContext(local_context)
+ : nullptr;
+ if (inspector) inspector->asyncTaskStarted(this);
result = script->Run(local_context);
+ if (inspector) inspector->asyncTaskFinished(this);
}
« test/inspector/inspector-test.cc ('K') | « test/inspector/task-runner.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698