[inspector] add async instrumentation for setTimeout in tests

test/inspector/inspector-test.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(_WIN32) && !defined(_WIN64)
 #include <unistd.h>  // NOLINT
 #endif               // !defined(_WIN32) && !defined(_WIN64)
 
 #include <locale.h>
 
@@ skipping 159 matching lines @@
     if (args.Length() != 4 || !args[0]->IsString() || !args[1]->IsString() ||
         !args[2]->IsInt32() || !args[3]->IsInt32()) {
       fprintf(stderr,
               "Internal error: compileAndRunWithOrigin(source, name, line, "
               "column).");
       Exit();
     }
 
     backend_runner_->Append(new ExecuteStringTask(
         ToVector(args[0].As<v8::String>()), args[1].As<v8::String>(),
-        args[2].As<v8::Int32>(), args[3].As<v8::Int32>()));
+        args[2].As<v8::Int32>(), args[3].As<v8::Int32>(), false));
   }
 };
 
 TaskRunner* UtilsExtension::backend_runner_ = nullptr;
 
 class SetTimeoutTask : public TaskRunner::Task {
  public:
   SetTimeoutTask(v8::Isolate* isolate, v8::Local<v8::Function> function)
       : function_(isolate, function) {}
   virtual ~SetTimeoutTask() {}
 
   bool is_inspector_task() final { return false; }
 
   void Run(v8::Isolate* isolate,
            const v8::Global<v8::Context>& global_context) override {
     v8::MicrotasksScope microtasks_scope(isolate,
                                          v8::MicrotasksScope::kRunMicrotasks);
     v8::HandleScope handle_scope(isolate);
     v8::Local<v8::Context> context = global_context.Get(isolate);
     v8::Context::Scope context_scope(context);
 
     v8::Local<v8::Function> function = function_.Get(isolate);
     v8::MaybeLocal<v8::Value> result;
     v8_inspector::V8Inspector* inspector =
         InspectorClientImpl::InspectorFromContext(context);
-    if (inspector) inspector->willExecuteScript(context, function->ScriptId());
+    if (inspector) {
+      inspector->willExecuteScript(context, function->ScriptId());
+      inspector->asyncTaskStarted(this);
+    }
     result = function->Call(context, context->Global(), 0, nullptr);
-    if (inspector) inspector->didExecuteScript(context);
+    if (inspector) {
+      inspector->asyncTaskFinished(this);
+      inspector->didExecuteScript(context);
+    }
   }
 
  private:
   v8::Global<v8::Function> function_;
 };
 
 class SetTimeoutExtension : public v8::Extension {
  public:
   SetTimeoutExtension()
       : v8::Extension("v8_inspector/setTimeout",
                       "native function setTimeout();") {}
 
   virtual v8::Local<v8::FunctionTemplate> GetNativeFunctionTemplate(
       v8::Isolate* isolate, v8::Local<v8::String> name) {
     return v8::FunctionTemplate::New(isolate, SetTimeoutExtension::SetTimeout);
   }
 
  private:
   static void SetTimeout(const v8::FunctionCallbackInfo<v8::Value>& args) {
     if (args.Length() != 2 || !args[1]->IsNumber() ||
         (!args[0]->IsFunction() && !args[0]->IsString()) ||
         args[1].As<v8::Number>()->Value() != 0.0) {
       fprintf(stderr,
               "Internal error: only setTimeout(function, 0) is supported.");
       Exit();
     }
     v8::Isolate* isolate = args.GetIsolate();
     v8::Local<v8::Context> context = isolate->GetCurrentContext();
+    std::unique_ptr<TaskRunner::Task> task;
     if (args[0]->IsFunction()) {
-      TaskRunner::FromContext(context)->Append(
+      task.reset(
           new SetTimeoutTask(isolate, v8::Local<v8::Function>::Cast(args[0])));
     } else {
-      TaskRunner::FromContext(context)->Append(new ExecuteStringTask(
+      task.reset(new ExecuteStringTask(
           ToVector(args[0].As<v8::String>()), v8::String::Empty(isolate),
-          v8::Integer::New(isolate, 0), v8::Integer::New(isolate, 0)));
+          v8::Integer::New(isolate, 0), v8::Integer::New(isolate, 0), true));
     }
+    const char* set_timeout = "setTimeout";
+    v8_inspector::V8Inspector* inspector =
+        InspectorClientImpl::InspectorFromContext(context);
+    if (inspector) {
+      inspector->asyncTaskScheduled(

[dgozman, 2016/12/13 17:31:54]

Why doesn't ExecuteStringTask do this in constructor if last parameter is true?
We can change that to be "char* asyncTaskName".

You can also inherit both SetTimeoutTask and ExecuteStringTask from AsyncTask if
that would make it easier.

[kozy, 2016/12/13 18:24:26]

Done.

+          v8_inspector::StringView(
+              reinterpret_cast<const uint8_t*>(set_timeout),
+              strlen(set_timeout)),
+          task.get(), false);
+    }
+    TaskRunner::FromContext(context)->Append(task.release());
   }
 };
 
 class InspectorExtension : public v8::Extension {
  public:
   InspectorExtension()
       : v8::Extension("v8_inspector/inspector",
                       "native function attachInspector();"
                       "native function detachInspector();") {}
 
@@ skipping 74 matching lines @@
     v8::Local<v8::String> message_string = ToString(isolate, message);
     v8::Local<v8::String> suffix =
         v8::String::NewFromUtf8(isolate, ")", v8::NewStringType::kInternalized)
             .ToLocalChecked();
 
     v8::Local<v8::String> result = v8::String::Concat(prefix, message_string);
     result = v8::String::Concat(result, suffix);
 
     frontend_task_runner_->Append(new ExecuteStringTask(
         ToVector(result), v8::String::Empty(isolate),
-        v8::Integer::New(isolate, 0), v8::Integer::New(isolate, 0)));
+        v8::Integer::New(isolate, 0), v8::Integer::New(isolate, 0), false));
   }
 
  private:
   TaskRunner* frontend_task_runner_;
 };
 
 }  //  namespace
 
 int main(int argc, char* argv[]) {
   v8::V8::InitializeICUDefaultLocation(argv[0]);
@@ skipping 49 matching lines @@
               argv[i]);
       Exit();
     }
     frontend_runner.Append(new ExecuteStringTask(chars));
   }
 
   frontend_runner.Join();
   backend_runner.Join();
   return 0;
 }