Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2574793002: [Editing] Store |CommandSource| in |CompositeEditCommand| (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index c120291d15c7cccaf88e0c059c0c63ff2bb5bdc8..f1890aa64f92a21d2e4a7d78c4aa03c293efaafc 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -112,6 +112,7 @@
#include "core/editing/InputMethodController.h"
#include "core/editing/PlainTextRange.h"
#include "core/editing/TextAffinity.h"
+#include "core/editing/commands/CompositeEditCommand.h"
Xiaocheng 2016/12/14 05:13:15 Besides, ideally we would like not to make anythin
chongz 2016/12/15 00:53:33 Changed |CommandSource| to be a default parameter
#include "core/editing/iterators/TextIterator.h"
#include "core/editing/serializers/Serialization.h"
#include "core/editing/spellcheck/SpellChecker.h"
@@ -952,8 +953,8 @@ void WebLocalFrameImpl::replaceSelection(const WebString& text) {
frame()->editor().behavior().shouldSelectReplacement();
bool smartReplace = true;
frame()->editor().replaceSelectionWithText(
- text, selectReplacement, smartReplace,
- InputEvent::InputType::InsertReplacementText);
+ blink::CommandSource::MenuOrKeyBinding, text, selectReplacement,
+ smartReplace, InputEvent::InputType::InsertReplacementText);
}
void WebLocalFrameImpl::setMarkedText(const WebString& text,

Powered by Google App Engine
This is Rietveld 408576698