Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h

Issue 2574793002: [Editing] Store |CommandSource| in |CompositeEditCommand| (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h
index 81f9a4ee4c7860c1c65418456faad0a03916373b..882c87ad1aaddbedc38d18016a5273441cf52dc7 100644
--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h
@@ -37,17 +37,20 @@ class CORE_EXPORT DeleteSelectionCommand final : public CompositeEditCommand {
public:
static DeleteSelectionCommand* create(
Document& document,
+ CommandSource source,
bool smartDelete = false,
bool mergeBlocksAfterDelete = true,
bool expandForSpecialElements = false,
bool sanitizeMarkup = true,
InputEvent::InputType inputType = InputEvent::InputType::None,
const Position& referenceMovePosition = Position()) {
- return new DeleteSelectionCommand(
- document, smartDelete, mergeBlocksAfterDelete, expandForSpecialElements,
- sanitizeMarkup, inputType, referenceMovePosition);
+ return new DeleteSelectionCommand(document, source, smartDelete,
+ mergeBlocksAfterDelete,
+ expandForSpecialElements, sanitizeMarkup,
+ inputType, referenceMovePosition);
}
static DeleteSelectionCommand* create(
+ CommandSource source,
const VisibleSelection& selection,
bool smartDelete = false,
bool mergeBlocksAfterDelete = true,
@@ -55,7 +58,7 @@ class CORE_EXPORT DeleteSelectionCommand final : public CompositeEditCommand {
bool sanitizeMarkup = true,
InputEvent::InputType inputType = InputEvent::InputType::None) {
return new DeleteSelectionCommand(
- selection, smartDelete, mergeBlocksAfterDelete,
+ source, selection, smartDelete, mergeBlocksAfterDelete,
expandForSpecialElements, sanitizeMarkup, inputType);
}
@@ -63,13 +66,15 @@ class CORE_EXPORT DeleteSelectionCommand final : public CompositeEditCommand {
private:
DeleteSelectionCommand(Document&,
+ CommandSource,
bool smartDelete,
bool mergeBlocksAfterDelete,
bool expandForSpecialElements,
bool santizeMarkup,
InputEvent::InputType,
const Position& referenceMovePosition);
- DeleteSelectionCommand(const VisibleSelection&,
+ DeleteSelectionCommand(CommandSource,
+ const VisibleSelection&,
bool smartDelete,
bool mergeBlocksAfterDelete,
bool expandForSpecialElements,

Powered by Google App Engine
This is Rietveld 408576698