third_party/WebKit/Source/core/dom/DatasetDOMStringMap.cpp - Issue 2574773002: Migrate WTF::Vector::append() to ::push_back() [part 4 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DatasetDOMStringMap.cpp

Issue 2574773002: Migrate WTF::Vector::append() to ::push_back() [part 4 of N] (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DatasetDOMStringMap.cpp

diff --git a/third_party/WebKit/Source/core/dom/DatasetDOMStringMap.cpp b/third_party/WebKit/Source/core/dom/DatasetDOMStringMap.cpp

index ee7a019b71d553c223242d72a456b366a996e4ed..e006a7a19a77ea4d177ffc12dc3961a0294432ca 100644

--- a/third_party/WebKit/Source/core/dom/DatasetDOMStringMap.cpp

+++ b/third_party/WebKit/Source/core/dom/DatasetDOMStringMap.cpp

@@ -153,7 +153,7 @@ void DatasetDOMStringMap::getNames(Vector<String>& names) {

AttributeCollection attributes = m_element->attributes();

for (const Attribute& attr : attributes) {

if (isValidAttributeName(attr.localName()))

- names.append(convertAttributeNameToPropertyName(attr.localName()));

+ names.push_back(convertAttributeNameToPropertyName(attr.localName()));

}