chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc - Issue 2574763003: Remove chrome-extension-resource:// scheme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

Issue 2574763003: Remove chrome-extension-resource:// scheme (Closed)

Patch Set: Silently strip chrome-extension-resource:// from CSP directives. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/BUILD.gn ('k') | chrome/browser/extensions/extension_resource_protocols.h » ('j') | extensions/shell/common/shell_content_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

diff --git a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

index bee125700dff5cec5d9e36c0a39c0d82fe99cefb..188470418158ac4818528f55830ee1e778092b62 100644

--- a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

+++ b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

@@ -506,7 +506,6 @@ bool ChromeContentBrowserClientExtensionsPart::AllowServiceWorker(

int render_process_id,

int render_frame_id) {

// We only care about extension urls.

- // TODO(devlin): Also address chrome-extension-resource.

if (!first_party_url.SchemeIs(kExtensionScheme))

return true;