Disable lazy parsing inside eval (see bug).

test/mjsunit/regress/regress-5736.js

Index: test/mjsunit/regress/regress-5736.js
diff --git a/test/mjsunit/regress/regress-5736.js b/test/mjsunit/regress/regress-5736.js
new file mode 100644
index 0000000000000000000000000000000000000000..2813f2ce7681eace9b8fd321e6a477c990b1fa29
--- /dev/null
+++ b/test/mjsunit/regress/regress-5736.js
@@ -0,0 +1,17 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var my_global = 0;
+
+// The problem was that we allowed lazy functions inside evals, but did not
+// force context allocation on the eval scope. Thus, foo was not context
+// allocated since we didn't realize that a lazy function referred to it.
+eval("let foo = 1; function maybe_lazy() { foo = 2; } maybe_lazy(); my_global = foo;");

[adamk, 2016/12/15 13:11:48]

Nit: you could use a template literal to split this across multiple lines and
make it a little easier to read.

[adamk, 2016/12/15 13:11:48]

You could make this test pass without Dan's fix by storing maybe_lazy in another
let-bound variable, i.e.,

let maybe_lazy = function() { foo = 2 };

[marja, 2016/12/15 13:48:07]

Done.

[marja, 2016/12/15 13:48:07]

Done.

+assertEquals(my_global, 2);

[adamk, 2016/12/15 13:11:48]

assertEquals takes (expected, actual) I think?

[marja, 2016/12/15 13:48:07]

Done.

+
+(function TestVarInStrictEval() {
+  "use strict"

[adamk, 2016/12/15 13:11:48]

Please add a semicolon here.

[marja, 2016/12/15 13:48:07]

Done.

+  eval("var foo = 3; function maybe_lazy() { foo = 4; } maybe_lazy(); my_global = foo;");

[adamk, 2016/12/15 13:11:48]

Same here regarding template literal.

[marja, 2016/12/15 13:48:07]

Done.

+  assertEquals(my_global, 4);

[adamk, 2016/12/15 13:11:48]

And same assertEquals comment.

[marja, 2016/12/15 13:48:07]

Done.

+})();