Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: test/mjsunit/regress/regress-5736.js

Issue 2574753002: Disable lazy parsing inside eval (see bug). (Closed)
Patch Set: code review (adamk@) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/bugs/bug-2728.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-5736.js
diff --git a/test/mjsunit/regress/regress-5736.js b/test/mjsunit/regress/regress-5736.js
new file mode 100644
index 0000000000000000000000000000000000000000..6dcc0de7f47edd7e8387a63897db02593b1727a9
--- /dev/null
+++ b/test/mjsunit/regress/regress-5736.js
@@ -0,0 +1,23 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var my_global = 0;
+
+// The problem was that we allowed lazy functions inside evals, but did not
+// force context allocation on the eval scope. Thus, foo was not context
+// allocated since we didn't realize that a lazy function referred to it.
+eval(`let foo = 1;
+ let maybe_lazy = function() { foo = 2; }
+ maybe_lazy();
+ my_global = foo;`);
+assertEquals(2, my_global);
+
+(function TestVarInStrictEval() {
+ "use strict";
+ eval(`var foo = 3;
+ let maybe_lazy = function() { foo = 4; }
+ maybe_lazy();
+ my_global = foo;`);
+ assertEquals(4, my_global);
+})();
« no previous file with comments | « test/mjsunit/bugs/bug-2728.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698