Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: test/mjsunit/regress/regress-5736.js

Issue 2574753002: Disable lazy parsing inside eval (see bug). (Closed)
Patch Set: code review (adamk@) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/bugs/bug-2728.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 var my_global = 0;
6
7 // The problem was that we allowed lazy functions inside evals, but did not
8 // force context allocation on the eval scope. Thus, foo was not context
9 // allocated since we didn't realize that a lazy function referred to it.
10 eval(`let foo = 1;
11 let maybe_lazy = function() { foo = 2; }
12 maybe_lazy();
13 my_global = foo;`);
14 assertEquals(2, my_global);
15
16 (function TestVarInStrictEval() {
17 "use strict";
18 eval(`var foo = 3;
19 let maybe_lazy = function() { foo = 4; }
20 maybe_lazy();
21 my_global = foo;`);
22 assertEquals(4, my_global);
23 })();
OLDNEW
« no previous file with comments | « test/mjsunit/bugs/bug-2728.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698