Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4094)

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl.cc

Issue 2574673002: Removes ScopedVector from presentation_service_impl. (Closed)
Patch Set: Addresses Avi's #3 comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/presentation_service_delegate_impl.cc
diff --git a/chrome/browser/media/router/presentation_service_delegate_impl.cc b/chrome/browser/media/router/presentation_service_delegate_impl.cc
index c2603932ed1cb2c39e6f980431b14ade27930caf..8c0a4f3716fa12eecb3f4df14c2658584a23e8dd 100644
--- a/chrome/browser/media/router/presentation_service_delegate_impl.cc
+++ b/chrome/browser/media/router/presentation_service_delegate_impl.cc
@@ -91,15 +91,18 @@ class PresentationSessionMessagesObserver : public RouteMessageObserver {
void OnMessagesReceived(const std::vector<RouteMessage>& messages) final {
DVLOG(2) << __func__ << ", number of messages : " << messages.size();
- ScopedVector<content::PresentationSessionMessage> presentation_messages;
+ std::vector<std::unique_ptr<content::PresentationSessionMessage>>
+ presentation_messages;
for (const RouteMessage& message : messages) {
if (message.type == RouteMessage::TEXT && message.text) {
- presentation_messages.push_back(new content::PresentationSessionMessage(
- content::PresentationMessageType::TEXT));
+ presentation_messages.push_back(
+ base::MakeUnique<content::PresentationSessionMessage>(
+ content::PresentationMessageType::TEXT));
presentation_messages.back()->message = *message.text;
} else if (message.type == RouteMessage::BINARY && message.binary) {
- presentation_messages.push_back(new content::PresentationSessionMessage(
- content::PresentationMessageType::ARRAY_BUFFER));
+ presentation_messages.push_back(
+ base::MakeUnique<content::PresentationSessionMessage>(
+ content::PresentationMessageType::ARRAY_BUFFER));
presentation_messages.back()->data.reset(
new std::vector<uint8_t>(*message.binary));
}

Powered by Google App Engine
This is Rietveld 408576698