Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: tools/gn/xcode_writer.h

Issue 2574643002: Add functionality to find xctest files under application target. (Closed)
Patch Set: Update comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/gn/xcode_writer.cc » ('j') | tools/gn/xcode_writer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_XCODE_WRITER_H_ 5 #ifndef TOOLS_GN_XCODE_WRITER_H_
6 #define TOOLS_GN_XCODE_WRITER_H_ 6 #define TOOLS_GN_XCODE_WRITER_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 // Filters the list of targets to only return the targets with artifacts 58 // Filters the list of targets to only return the targets with artifacts
59 // usable from Xcode (mostly application bundles). On failure populate |err| 59 // usable from Xcode (mostly application bundles). On failure populate |err|
60 // and return false. 60 // and return false.
61 static bool FilterTargets(const BuildSettings* build_settings, 61 static bool FilterTargets(const BuildSettings* build_settings,
62 const std::vector<const Target*>& all_targets, 62 const std::vector<const Target*>& all_targets,
63 const std::string& dir_filters_string, 63 const std::string& dir_filters_string,
64 std::vector<const Target*>* targets, 64 std::vector<const Target*>* targets,
65 Err* err); 65 Err* err);
66 66
67 // Filters the list of targets to only return xctest targets and their
68 // corresonding application targets.
sdefresne 2016/12/14 13:00:03 nit: corresonding -> corresponding
liaoyuke 2016/12/15 00:03:12 Done.
69 static void FilterXCTestTargets(
70 const std::vector<const Target*>& targets,
71 std::vector<const Target*>* xctest_targets,
72 std::vector<const Target*>* application_targets);
73
67 // Generate the "products.xcodeproj" project that reference all products 74 // Generate the "products.xcodeproj" project that reference all products
68 // (i.e. targets that have a build artefact usable from Xcode, mostly 75 // (i.e. targets that have a build artefact usable from Xcode, mostly
69 // application bundles). 76 // application bundles).
70 void CreateProductsProject(const std::vector<const Target*>& targets, 77 void CreateProductsProject(const std::vector<const Target*>& targets,
71 const PBXAttributes& attributes, 78 const PBXAttributes& attributes,
72 const std::string& source_path, 79 const std::string& source_path,
73 const std::string& config_name, 80 const std::string& config_name,
74 const std::string& root_target, 81 const std::string& root_target,
75 const std::string& ninja_extra_args, 82 const std::string& ninja_extra_args,
76 const BuildSettings* build_settings, 83 const BuildSettings* build_settings,
(...skipping 17 matching lines...) Expand all
94 void WriteWorkspaceContent(std::ostream& out); 101 void WriteWorkspaceContent(std::ostream& out);
95 void WriteProjectContent(std::ostream& out, PBXProject* project); 102 void WriteProjectContent(std::ostream& out, PBXProject* project);
96 103
97 std::string name_; 104 std::string name_;
98 std::vector<std::unique_ptr<PBXProject>> projects_; 105 std::vector<std::unique_ptr<PBXProject>> projects_;
99 106
100 DISALLOW_COPY_AND_ASSIGN(XcodeWriter); 107 DISALLOW_COPY_AND_ASSIGN(XcodeWriter);
101 }; 108 };
102 109
103 #endif // TOOLS_GN_XCODE_WRITER_H_ 110 #endif // TOOLS_GN_XCODE_WRITER_H_
OLDNEW
« no previous file with comments | « no previous file | tools/gn/xcode_writer.cc » ('j') | tools/gn/xcode_writer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698