Add functionality to find xctest files under application target.

tools/gn/xcode_writer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/xcode_writer.h"
 
 #include <iomanip>
 #include <map>
 #include <memory>
 #include <sstream>
@@ skipping 13 matching lines @@
 #include "tools/gn/filesystem_utils.h"
 #include "tools/gn/settings.h"
 #include "tools/gn/source_file.h"
 #include "tools/gn/target.h"
 #include "tools/gn/value.h"
 #include "tools/gn/variables.h"
 #include "tools/gn/xcode_object.h"
 
 namespace {
 
+using TargetToFileList = std::unordered_map<const Target*, Target::FileList>;
+
+const char kEarlGreyFileNameIdentifier[] = "egtest.mm";
+

[justincohen, 2016/12/15 00:30:24]

Is there a better, less sticky way of finding Xctests?  Do we need to worry
about xctests that aren't eg?

 struct SafeEnvironmentVariableInfo {
   const char* name;
   bool capture_at_generation;
 };
 
 SafeEnvironmentVariableInfo kSafeEnvironmentVariables[] = {
     {"HOME", true}, {"LANG", true},    {"PATH", true},
     {"USER", true}, {"TMPDIR", false},
 };
 
@@ skipping 35 matching lines @@
 
   script << "ninja -C .";
   if (!ninja_extra_args.empty())
     script << " " << ninja_extra_args;
   if (!target_name.empty())
     script << " " << target_name;
   script << "\nexit 1\n";
   return script.str();
 }
 
+// Finds the list of earl grey files recursively under |target|.
+void GetEarlGreyFiles(const Target* target,
+                      TargetToFileList* eg_files_per_target) {
+  // Early return if already visited and processed.
+  if (eg_files_per_target->find(target) != eg_files_per_target->end())
+    return;
+
+  Target::FileList eg_files;
+  for (const SourceFile& file : target->sources()) {
+    if (base::EndsWith(file.GetName(), kEarlGreyFileNameIdentifier,
+                       base::CompareCase::SENSITIVE)) {
+      eg_files.push_back(file);
+    }
+  }
+
+  // Call recursively on public and private deps.
+  for (const auto& target : target->public_deps()) {
+    GetEarlGreyFiles(target.ptr, eg_files_per_target);
+    const Target::FileList& deps_eg_files = (*eg_files_per_target)[target.ptr];
+    eg_files.insert(eg_files.end(), deps_eg_files.begin(), deps_eg_files.end());
+  }
+
+  for (const auto& target : target->private_deps()) {
+    GetEarlGreyFiles(target.ptr, eg_files_per_target);
+    const Target::FileList& deps_eg_files = (*eg_files_per_target)[target.ptr];
+    eg_files.insert(eg_files.end(), deps_eg_files.begin(), deps_eg_files.end());
+  }
+
+  // Sort eg_files to remove duplicates.
+  std::sort(eg_files.begin(), eg_files.end());
+  eg_files.erase(std::unique(eg_files.begin(), eg_files.end()), eg_files.end());
+
+  eg_files_per_target->insert(std::make_pair(target, eg_files));
+}
+
+// Finds the list of earl grey files recursively under each of the application
+// target.
+void GetEarlGreyFilesForAll(
+    const std::vector<const Target*>& application_targets,
+    std::vector<Target::FileList>* file_lists) {
+  TargetToFileList eg_files_per_target;
+
+  for (const Target* target : application_targets) {
+    GetEarlGreyFiles(target, &eg_files_per_target);
+    file_lists->push_back(eg_files_per_target[target]);
+  }
+}
+
+bool IsApplicationTarget(const Target* target) {
+  return target->output_type() == Target::CREATE_BUNDLE &&
+         target->bundle_data().product_type() ==
+             "com.apple.product-type.application";
+}
+
 class CollectPBXObjectsPerClassHelper : public PBXObjectVisitor {
  public:
   CollectPBXObjectsPerClassHelper() {}
 
   void Visit(PBXObject* object) override {
     DCHECK(object);
     objects_per_class_[object->Class()].push_back(object);
   }
 
   const std::map<PBXObjectClass, std::vector<const PBXObject*>>&
@@ skipping 160 matching lines @@
   // Sort the list of targets per-label to get a consistent ordering of them
   // in the generated Xcode project (and thus stability of the file generated).
   std::sort(targets->begin(), targets->end(),
             [](const Target* a, const Target* b) {
               return a->label().name() < b->label().name();
             });
 
   return true;
 }
 
+// static
+void XcodeWriter::FilterApplicationTargets(
+    const std::vector<const Target*>& targets,
+    std::vector<const Target*>* application_targets) {
+  // Filter out all targets of type CREATE_BUNDLE and whose bundle_data has
+  // product_type: "com.apple.product-type.application".
+  for (const Target* target : targets) {
+    if (!IsApplicationTarget(target))
+      continue;
+
+    application_targets->push_back(target);
+  }
+}
+
 void XcodeWriter::CreateProductsProject(
     const std::vector<const Target*>& targets,
     const PBXAttributes& attributes,
     const std::string& source_path,
     const std::string& config_name,
     const std::string& root_target,
     const std::string& ninja_extra_args,
     const BuildSettings* build_settings,
     TargetOsType target_os) {
   std::unique_ptr<PBXProject> main_project(
       new PBXProject("products", config_name, source_path, attributes));
 
+  // Filter application targets and find list of earl grey test files
+  // recursively under them.
+  std::vector<const Target*> xctest_targets;
+  std::vector<const Target*> application_targets;
+  std::vector<Target::FileList> earl_grey_file_lists;
+  XcodeWriter::FilterApplicationTargets(targets, &application_targets);
+  GetEarlGreyFilesForAll(application_targets, &earl_grey_file_lists);
+
   std::string build_path;
   std::unique_ptr<base::Environment> env(base::Environment::Create());
 
   main_project->AddAggregateTarget(
       "All", GetBuildScript(root_target, ninja_extra_args, env.get()));
 
   for (const Target* target : targets) {
     switch (target->output_type()) {
       case Target::EXECUTABLE:
         if (target_os == XcodeWriter::WRITER_TARGET_OS_IOS)
@@ skipping 136 matching lines @@
     for (auto* object : pair.second) {
       object->Print(out, 2);
     }
     out << "/* End " << ToString(pair.first) << " section */\n";
   }
 
   out << "\t};\n"
       << "\trootObject = " << project->Reference() << ";\n"
       << "}\n";
 }