Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 257463007: Work around --profiler=perf failure with recent linux perf. (Closed)

Created:
6 years, 8 months ago by eseidel
Modified:
6 years, 8 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Work around --profiler=perf failure with recent linux perf. Looks like perf --call-graph now requires an argument in the most recent perf binary. That's probably a bug in perf, but moving back to -g for now. I tried running the telemetry tests, but gave up after several minutes of gorilla videos stealing focus from my browser. I found src/tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py but it didn't seem to attempt to test this code (or have a recommended way for instantiating this kind of PerfProfiler so I could call this instance method) so I gave up on testing. BUG=366928 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
eseidel
6 years, 8 months ago (2014-04-25 00:06:49 UTC) #1
dtu
lgtm
6 years, 8 months ago (2014-04-25 02:01:21 UTC) #2
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-04-25 02:14:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/257463007/1
6 years, 8 months ago (2014-04-25 02:15:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 02:21:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-25 02:21:42 UTC) #6
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-04-25 03:05:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/257463007/1
6 years, 8 months ago (2014-04-25 03:05:24 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 23:02:53 UTC) #9
Message was sent while issue was closed.
Change committed as 266272

Powered by Google App Engine
This is Rietveld 408576698