Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257463002: Indent for each IPC_STRUCT_MEMBER in embedded_worker_messages.h (Closed)

Created:
6 years, 8 months ago by horo
Modified:
6 years, 8 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Indent for each IPC_STRUCT_MEMBER in embedded_worker_messages.h BUG=365235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/common/service_worker/embedded_worker_messages.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
horo
tsepez@ Please review this. Thank you.
6 years, 8 months ago (2014-04-24 01:18:29 UTC) #1
Tom Sepez
LGTM. (I'm actually OK with either indent style, but this one seems more common).
6 years, 8 months ago (2014-04-24 04:16:11 UTC) #2
horo
The CQ bit was checked by horo@chromium.org
6 years, 8 months ago (2014-04-24 04:31:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/257463002/1
6 years, 8 months ago (2014-04-24 05:02:35 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 06:44:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 06:44:04 UTC) #6
horo
The CQ bit was checked by horo@chromium.org
6 years, 8 months ago (2014-04-24 10:52:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/257463002/1
6 years, 8 months ago (2014-04-24 10:56:57 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 16:24:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 16:24:58 UTC) #10
horo
The CQ bit was checked by horo@chromium.org
6 years, 8 months ago (2014-04-24 23:23:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/257463002/1
6 years, 8 months ago (2014-04-24 23:24:56 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 00:56:00 UTC) #13
Message was sent while issue was closed. 
Change committed as 266073

Powered by Google App Engine
This is Rietveld 408576698