Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

Issue 2574603002: DevTools: Fix Elements tab event listener removal (Closed)
Patch Set: add test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
index 518f686550c3770b24a824cd6143f1a4e859e245..788370bdeb62120f360da3c401a6052b0ba40bfc 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
@@ -319,7 +319,7 @@ InspectorTest.dumpObjectPropertyTreeElement = function(treeElement)
}
}
-InspectorTest.expandAndDumpEventListeners = function(eventListenersView, callback)
+InspectorTest.expandAndDumpEventListeners = function(eventListenersView, callback, force)
{
InspectorTest.addSniffer(Components.EventListenersView.prototype, "_eventListenersArrivedForTest", listenersArrived);
@@ -352,6 +352,9 @@ InspectorTest.expandAndDumpEventListeners = function(eventListenersView, callbac
}
callback();
}
+
+ if (force)
lushnikov 2016/12/15 22:33:16 let's rather do: if (force) lstenersArrived
phulce 2016/12/16 18:41:56 Went back and forth and that actually, good point
+ Components.EventListenersView.prototype._eventListenersArrivedForTest();
}
InspectorTest.dumpNavigatorView = function(navigatorView)

Powered by Google App Engine
This is Rietveld 408576698