Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: third_party/WebKit/Source/platform/BUILD.gn

Issue 2574593003: Fix Windows build warning LNK4217 for blink_platform.dll. (Closed)
Patch Set: Rebase Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/BUILD.gn
diff --git a/third_party/WebKit/Source/platform/BUILD.gn b/third_party/WebKit/Source/platform/BUILD.gn
index d4cab47adf1e55e83112cd146b99f3c78d3f37cf..a38d3df3f011b2a3b8e13e4c9edabc0693add45e 100644
--- a/third_party/WebKit/Source/platform/BUILD.gn
+++ b/third_party/WebKit/Source/platform/BUILD.gn
@@ -1129,7 +1129,6 @@ component("platform") {
"mhtml/MHTMLParser.cpp",
"mhtml/MHTMLParser.h",
"mojo/CommonCustomTypesStructTraits.cpp",
- "mojo/GeometryStructTraits.cpp",
"mojo/MojoHelper.h",
"network/ContentSecurityPolicyParsers.cpp",
"network/ContentSecurityPolicyParsers.h",
@@ -1518,14 +1517,6 @@ component("platform") {
"/wd4334", # Result of 32-bit shift implicitly converted to 64 bits.
"/wd4724", # Modulo by 0.
]
-
- # crbug.com/654776: Suppress symbol import warnings.
- if (is_component_build) {
- ldflags = [
- "/ignore:4217",
- "/ignore:4049",
- ]
- }
} else {
sources -= [
"clipboard/ClipboardUtilitiesWin.cpp",
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/mojo/BUILD.gn » ('j') | third_party/WebKit/Source/platform/mojo/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698