third_party/WebKit/Source/platform/mojo/GeometryStructTraits.cpp - Issue 2574593003: Fix Windows build warning LNK4217 for blink_platform.dll.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/mojo/GeometryStructTraits.cpp

Issue 2574593003: Fix Windows build warning LNK4217 for blink_platform.dll. (Closed)

Patch Set: Do not export geometry struct traits from blink_platform.dll Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "platform/mojo/GeometryStructTraits.h"	5 #include "third_party/WebKit/Source/platform/mojo/GeometryStructTraits.h"

6	6

7 namespace mojo {	7 namespace mojo {

8	8

9 // static	9 // static

10 bool StructTraits<gfx::mojom::blink::Size::DataView, ::blink::WebSize>::Read(	10 bool StructTraits<gfx::mojom::blink::Size::DataView, ::blink::WebSize>::Read(

11 gfx::mojom::blink::Size::DataView data,	11 gfx::mojom::blink::Size::DataView data,

12 ::blink::WebSize* out) {	12 ::blink::WebSize* out) {

13 if (data.width() < 0 \|\| data.height() < 0)	13 if (data.width() < 0 \|\| data.height() < 0)

14 return false;	14 return false;

15 out->width = data.width();	15 out->width = data.width();

16 out->height = data.height();	16 out->height = data.height();

17 return true;	17 return true;

18 }	18 }

19	19

20 } // namespace mojo	20 } // namespace mojo

OLD	NEW