third_party/WebKit/Source/platform/mojo/BUILD.gn - Issue 2574593003: Fix Windows build warning LNK4217 for blink_platform.dll.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/mojo/BUILD.gn

Issue 2574593003: Fix Windows build warning LNK4217 for blink_platform.dll. (Closed)

Patch Set: Do not export geometry struct traits from blink_platform.dll Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("geometry_struct_traits") {

	6 sources = [

	7 "GeometryStructTraits.cpp",

	8 "GeometryStructTraits.h",

	9 ]

	10 public_deps = [

	11 "//mojo/public/cpp/bindings:wtf_support",

	12 "//ui/gfx/geometry",

	13 "//ui/gfx/geometry/mojo:mojo_blink__generator",
	yzshen1 2016/12/19 17:34:56 Can it depend on ui/gfx/geometry/mojo:mojo_shared_ Can it depend on ui/gfx/geometry/mojo:mojo_shared_cpp_sources? __generator is not meant to be a public-facing target. You need to change the include in GeometryStructTraits.h to geometry.mojom-shared.h. And I don't think you need "//mojo/public/cpp/bindings:wtf_support" either. leonhsl(Using Gerrit) 2016/12/20 03:00:19 Done and Thanks. Understood more about traits now! Show quoted text On 2016/12/19 17:34:56, yzshen1 wrote: > Can it depend on ui/gfx/geometry/mojo:mojo_shared_cpp_sources? __generator is > not meant to be a public-facing target. > > You need to change the include in GeometryStructTraits.h to > geometry.mojom-shared.h. And I don't think you need > "//mojo/public/cpp/bindings:wtf_support" either. Done and Thanks. Understood more about traits now!
	14 ]

	15 }

OLD	NEW