Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 257453004: Disable content_browsertests WebUIMojoTest.EndToEndEcho, Ping due to flakiness (Closed)

Created:
6 years, 8 months ago by darin (slow to review)
Modified:
6 years, 8 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, ben+mojo_chromium.org
Visibility:
Public.

Description

Disable content_browsertests WebUIMojoTest.EndToEndEcho, Ping due to flakiness BUG=366644 R=viettrungluu@chromium.org TBR=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265955

Patch Set 1 #

Patch Set 2 : windows only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
darin (slow to review)
6 years, 8 months ago (2014-04-24 14:42:10 UTC) #1
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 8 months ago (2014-04-24 14:42:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/257453004/1
6 years, 8 months ago (2014-04-24 14:43:20 UTC) #3
viettrungluu
You could have disabled this only on Windows. <shrug> Rubberstamp LGTM.
6 years, 8 months ago (2014-04-24 14:49:55 UTC) #4
darin (slow to review)
The CQ bit was unchecked by darin@chromium.org
6 years, 8 months ago (2014-04-24 16:44:32 UTC) #5
darin (slow to review)
On 2014/04/24 14:49:55, viettrungluu wrote: > You could have disabled this only on Windows. <shrug> ...
6 years, 8 months ago (2014-04-24 16:45:02 UTC) #6
viettrungluu
lgtm
6 years, 8 months ago (2014-04-24 17:38:36 UTC) #7
darin (slow to review)
6 years, 8 months ago (2014-04-24 17:44:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r265955 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698