Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 257453002: Fix tc_malloc_skip_new_handler to work togather with heap profiler (Closed)

Created:
6 years, 8 months ago by kbalazs
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix tc_malloc_skip_new_handler to work together with heap profiler Need to be in google_malloc section just like every other alloc function. R=willchan@chromium.org BUG=364380 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/tcmalloc/chromium/src/tcmalloc.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
kbalazs
6 years, 8 months ago (2014-04-24 01:02:02 UTC) #1
willchan no longer on Chromium
lgtm
6 years, 8 months ago (2014-04-24 01:13:42 UTC) #2
Dai Mikurube (NOT FULLTIME)
lgtm. It worked also in my environment. Thanks!
6 years, 8 months ago (2014-04-24 03:56:46 UTC) #3
kbalazs
The CQ bit was checked by b.kelemen@samsung.com
6 years, 8 months ago (2014-04-24 17:54:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/257453002/1
6 years, 8 months ago (2014-04-24 21:54:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 23:27:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 23:27:33 UTC) #7
kbalazs
The CQ bit was checked by b.kelemen@samsung.com
6 years, 8 months ago (2014-04-25 15:16:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/257453002/1
6 years, 8 months ago (2014-04-25 21:45:56 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 04:37:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 04:37:20 UTC) #11
kbalazs
The CQ bit was checked by b.kelemen@samsung.com
6 years, 7 months ago (2014-04-28 04:51:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/257453002/1
6 years, 7 months ago (2014-04-28 04:51:57 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 06:40:46 UTC) #14
Message was sent while issue was closed.
Change committed as 266445

Powered by Google App Engine
This is Rietveld 408576698