Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/gn/xcode_object.h

Issue 2574333002: [Refactor Xcode Objects] Enable generating per file '--help' compiler flag (Closed)
Patch Set: Addressed feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/xcode_object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/xcode_object.h
diff --git a/tools/gn/xcode_object.h b/tools/gn/xcode_object.h
index 2ad43cceefc4567abad8d2ca2123794f0c0cf606..576e1dd07f313db256653adb79e056558f794d2f 100644
--- a/tools/gn/xcode_object.h
+++ b/tools/gn/xcode_object.h
@@ -151,10 +151,16 @@ class PBXAggregateTarget : public PBXTarget {
// PBXBuildFile ---------------------------------------------------------------
+enum class CompilerFlags {
sdefresne 2016/12/19 08:05:36 nit: move at the top of the file with other enums
liaoyuke 2016/12/19 08:17:42 Done.
+ NONE,
+ HELP,
+};
+
class PBXBuildFile : public PBXObject {
public:
PBXBuildFile(const PBXFileReference* file_reference,
- const PBXSourcesBuildPhase* build_phase);
+ const PBXSourcesBuildPhase* build_phase,
+ const CompilerFlags compiler_flag);
~PBXBuildFile() override;
// PXBObject implementation.
@@ -165,6 +171,7 @@ class PBXBuildFile : public PBXObject {
private:
const PBXFileReference* file_reference_;
const PBXSourcesBuildPhase* build_phase_;
+ const CompilerFlags compiler_flag_;
DISALLOW_COPY_AND_ASSIGN(PBXBuildFile);
};
@@ -247,7 +254,8 @@ class PBXNativeTarget : public PBXTarget {
const PBXFileReference* product_reference);
~PBXNativeTarget() override;
- void AddFileForIndexing(const PBXFileReference* file_reference);
+ void AddFileForIndexing(const PBXFileReference* file_reference,
+ const CompilerFlags compiler_flag);
// PBXObject implementation.
PBXObjectClass Class() const override;
@@ -271,7 +279,8 @@ class PBXProject : public PBXObject {
const PBXAttributes& attributes);
~PBXProject() override;
- void AddSourceFile(const std::string& source_path);
+ void AddSourceFile(const std::string& source_path,
+ const CompilerFlags compiler_flag);
void AddAggregateTarget(const std::string& name,
const std::string& shell_script);
void AddNativeTarget(const std::string& name,
« no previous file with comments | « no previous file | tools/gn/xcode_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698